Reducing allocations in parsing - #2001

Merged

adamsitnik merged 26 commits into

dotnet:mainfrom

adamsitnik:allocations

Dec 23, 2022

Commits on Dec 20, 2022

delay error list allocation until it's needed
adamsitnik
committed
52af22d
add nullable annotation for Parser.Parse(arguments), avoid allocation when it's actually null
adamsitnik
committed
105e592
minor Token cleanup
adamsitnik
committed
02c0daf
don't allocate a new list to normalize RootCommand
adamsitnik
committed
9741080
don't call EndsWith just to check one character
adamsitnik
committed
d6a5026
avoid allocations for parsing directives:
adamsitnik
committed
bc087b6
delay List<SyntaxNode> allocation
adamsitnik
committed
c38ccc1
token type checks can be performed only for debug builds (these are internal methods that we control)
adamsitnik
committed
d0e99ee
remove unused property that was allocating a list
adamsitnik
committed
e919201
delay List<OptionResult> allocation
adamsitnik
committed
11d72b0
delay List<ArgumentResult allocation
adamsitnik
committed
4a71f26
delay Dictionary<string, IReadOnlyList<string>> allocation
adamsitnik
committed
c0e3594
store the results of ParseResult.UnmatchedTokens and re-use it since it's creating a copy every time it's called!
adamsitnik
committed
e353656
avoid allocations when there are no unmatched tokens
adamsitnik
committed
b9c4d42

Commits on Dec 21, 2022

Commits on Dec 23, 2022

Aliases are internally backed by a HashSet, there is no point in creating a Union of the same hash set
adamsitnik
committed
4afe5b5
avoid list allocation
adamsitnik
committed
96c8e77
address code review feedback
adamsitnik
committed
0bb3b51