Respect custom help builder during parse error reporting - #2211
Merged
adamsitnik merged 2 commits intoJun 6, 2023
Conversation
adamsitnik
enabled auto-merge (squash)
June 6, 2023 14:52
Contributor
|
This conflicts with my changes in #2205, where I've removed the |
Member
Author
I am aware of that. This fixes solves the last bug that stops us from updating the SDK:
it would be really great to merge to be able to merge dotnet/sdk#29131 |
jonsequitur
approved these changes
Jun 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be the last bug for dotnet/sdk#29131 (at leas I hope so)