This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0] Fix PlatformManifestProjectReference ordering to fix flakiness - #7436
Merged
dagood merged 1 commit intoJul 27, 2019
Merged
Conversation
Props file import order meant OrderProjectReference Include="@(PlatformManifestProjectReference)" was being evaluated before PlatformManifestProjectReference was set. Solve this by moving the include to a new GetDefaultOrderProjectReferences target so the static prop order doesn't matter.
Member
Author
|
Merging to unblock CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Props file import order meant
OrderProjectReference Include="@(PlatformManifestProjectReference)"was being evaluated before PlatformManifestProjectReference was set. Solve this by moving the include to a new GetDefaultOrderProjectReferences target so the static prop order doesn't matter.Fixes Windows job CI flakiness introduced with #7372.
An alternative would be to change where the
PlatformManifestProjectReferenceis defined to put it before it's needed, but I find relying on static order makes the build harder to understand and debug, and less flexible.Somehow this didn't affect the initial PR... a lot of (all?) other 3.0 PRs are currently hitting this issue in CI, though.