Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Stop signing apphost.exe and comhost.dll in nupkg #7547

Merged
dagood merged 2 commits into from
Aug 2, 2019
Merged

Stop signing apphost.exe and comhost.dll in nupkg #7547

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
611c1a3
Stop signing apphost.exe and comhost.dll in nupkg
dagood Aug 2, 2019
055f4fb
Fix location of FileSignInfo
dagood Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
<!-- Find bundle artifacts, which need multiple stages to fully sign. -->
<BundleInstallerEngineArtifact Include="$(ArtifactsPackagesDir)**/*engine.exe" />
<BundleInstallerExeArtifact Include="$(ArtifactsPackagesDir)**/*.exe" />
</ItemGroup>

<!-- apphost and comhost template files are not signed, by design. -->
<FileSignInfo Include="apphost.exe;comhost.dll" CertificateName="None" />
</ItemGroup>>
Comment thread
dagood marked this conversation as resolved.

<ItemGroup Condition="'$(SignBinaries)' == 'true'">
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/hostfxr.dll" />
Expand All @@ -27,7 +30,6 @@
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/ijwhost.dll" />
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/winrthost.dll" />
<ItemsToSign Include="$(BaseOutputRootPath)corehost/**/nethost.dll" />
<!-- Note: apphost is not signed, by design. -->

<ItemsToSign Include="$(CrossGenRootPath)**/*.dll" />

Expand Down