This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix bundle installer signing - #7820
Merged
Merged
Conversation
This was referenced Aug 23, 2019
MichaelSimons
approved these changes
Aug 23, 2019
This OrderProjectReference is unnecessary: ensuring the MSI files are signed before bundling them is already handled by the infrastructure in the GetBundledMsiFiles target.
MichaelSimons
approved these changes
Aug 23, 2019
mmitche
approved these changes
Aug 23, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix bundle installer signing * Remove SignMsiFiles.proj MSBuild cycle This OrderProjectReference is unnecessary: ensuring the MSI files are signed before bundling them is already handled by the infrastructure in the GetBundledMsiFiles target. Commit migrated from dotnet/core-setup@9528017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/dotnet/core-setup/issues/7817.
The runtime MSI files weren't signed, due to a typo in
SharedFrameworkProjectpreventing the signing project from ensuring the correct build order.Fix the bundle signing project's references to the bundle projects. No items were found, causing
ReattachEngineToBundleto never run, and the signed bundle engine wasn't reattached.Bundle engine extraction/attachment was assuming the old, static 'dotnet-runtime' properties rather than current per-project properties. Based on logs, this seems like it would break windowsdesktop-runtime engine signing (if it were otherwise working).
Worked in validation build: https://dev.azure.com/dnceng/internal/_build/results?buildId=322283
We'll need this in 3.0 p9 to produce valid .NET Core Runtime and WindowsDesktop bundles. (https://github.com/dotnet/core-setup/issues/7817 for background.)
/cc @mmitche