This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable signing validation with exclusions - #7850
Merged
Merged
Conversation
MichaelSimons
approved these changes
Aug 26, 2019
MichaelSimons
left a comment
MichaelSimons
left a comment
Member
There was a problem hiding this comment.
LGTM - nice to see this get enabled. I also appreciate the effort to get the ball rolling even though there outstanding remaining issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/dotnet/core-setup/issues/5254. This validates that our nupkgs, MSIs, and bundle installer EXEs are signed and contain signed files.
A few missing pieces:
Signing.propsrather than checking in a separate txt file: SignValidationExclusionList does not work arcade#2888.Validation build: 325387