Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
12a2518
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] Aug 21, 2019
bf2ad25
Categorize shipping/nonshipping NuGet packages (#7792)
dagood Aug 21, 2019
9949243
Split blob publish into stages run before Arcade (#7796)
dagood Aug 21, 2019
851ae4f
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Aug 21, 2019
de78ba1
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 22, 2019
d149d55
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Aug 22, 2019
74e3e44
Stop the BAR publish job assigning channel early (#7808)
dagood Aug 22, 2019
31e5389
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 23, 2019
24da149
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 23, 2019
b91349f
[release/3.0] Fix bundle installer signing (#7821)
dagood Aug 23, 2019
abecfcd
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 23, 2019
cdace26
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Aug 23, 2019
47b9021
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 24, 2019
6a4311a
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 25, 2019
6ae8b38
Merge pull request #7830 from dotnet/darc-release/3.0-a733b14f-2a92-4…
mmitche Aug 25, 2019
872cded
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Aug 25, 2019
28f20a7
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 26, 2019
b33b6c2
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 27, 2019
d83ad80
Set up auto-update for infrastructure packages (#7853)
dagood Aug 27, 2019
bdda3db
Enable signing validation with exclusions (#7854)
dagood Aug 27, 2019
95d166e
[release/3.0] Update dependencies from dotnet/arcade (#7841)
dotnet-maestro[bot] Aug 27, 2019
02f28ce
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Aug 27, 2019
d90543c
Fix version info missing from native binaries (#7867)
dagood Aug 27, 2019
460d1a7
[release/3.0] Update dependencies from dotnet/coreclr (#7865)
dotnet-maestro[bot] Aug 27, 2019
1c0f7e3
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 28, 2019
a94f49b
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 28, 2019
843b627
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Aug 28, 2019
5bc760e
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 28, 2019
0175edb
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 29, 2019
8880d72
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Aug 29, 2019
d9afcf9
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 29, 2019
36fa439
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Aug 29, 2019
67eb1ec
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 30, 2019
4114a38
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 30, 2019
44e933b
Update dependencies from https://github.com/dotnet/coreclr build 2019…
dotnet-maestro[bot] Aug 30, 2019
b9dd6c9
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] Sep 3, 2019
f5fc582
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
dotnet-maestro[bot] Sep 4, 2019
73ce3a2
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] Sep 4, 2019
aad4ac8
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Sep 4, 2019
d28f018
Update dependencies from https://github.com/dotnet/standard build 201…
dotnet-maestro[bot] Sep 4, 2019
4e6fcb0
[release/3.0] Update dependencies from dotnet/arcade (#7902)
dotnet-maestro[bot] Sep 4, 2019
caee21f
Remove WPF ignored duplicates: improve validation (#7970)
dagood Sep 4, 2019
b2d71fc
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] Sep 5, 2019
caa8d3b
Update dependencies from https://github.com/dotnet/corefx build 20190…
dotnet-maestro[bot] Sep 5, 2019
948c7f0
Update dependencies from https://github.com/dotnet/arcade build 20190…
dotnet-maestro[bot] Sep 5, 2019
1d41807
Enable post-build publishing for 3.1 channels and fixup legacy channl…
mmitche Sep 5, 2019
16f3ecf
Merge remote-tracking branch 'upstream/release/3.0' into darc-release…
mmitche Sep 5, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -168,45 +168,44 @@ stages:
# Publish to Build Asset Registry in order to generate the ReleaseConfigs artifact.
- template: /eng/common/templates/job/publish-build-assets.yml
parameters:
publishUsingPipelines: true
dependsOn: PrepareSignedArtifacts
pool:
name: NetCoreInternal-Pool
queue: buildpool.windows.10.amd64.vs2017

# Stages-based publishing entry point
- template: eng\common\templates\post-build\post-build.yml
- template: /eng/stages/publish.yml
parameters:
dependsOn: [PrepareForPublish]
# Symbol validation is not ready yet. https://github.com/dotnet/arcade/issues/2871
enableSymbolValidation: false
# Doesn't work yet, not fully configured. https://github.com/dotnet/core-setup/issues/5254
enableSigningValidation: false
# SourceLink validation doesn't work in dev builds: tries to pull from GitHub. https://github.com/dotnet/arcade/issues/3604
enableSourceLinkValidation: false
# Allow symbol publish to emit expected warnings without failing the build. Include single
# quotes inside the string so that it passes through to MSBuild without script interference.
symbolPublishingAdditionalParameters: "'-warnAsError:$false'"

- template: /eng/stages/custom-publish.yml
parameters:
# Custom publish stage dependency configuration.
# - dependsOn: <ID of the Arcade stage that custom publish should run after>
# Publish channel configuration. The publish template wraps Arcade publishing and adds some
# extras that aren't implemented in Arcade yet.
#
# - dependsOn: <ID of the Arcade stage that finalization should run after>
# channel:
# name: <Name of this channel, for logging and readability>
# bar: <Name of the Arcade variable that contains the ID of this channel in BAR>
# storage: <Name of the Latest channel to publish to in dotnetcli blob storage>
dependsOnPublishStages:
- dependsOn: PublishValidation
- dependsOn: NetCore_Dev30_Publish_Validation
channel:
name: .NET Core 3 Dev
bar: PublicDevRelease_30_Channel_Id
storage: release/3.0
- dependsOn: PubRel_PublishValidation
- dependsOn: NetCore_Release30_Publish_Validation
channel:
name: .NET Core 3 Release
bar: PublicRelease_30_Channel_Id
storage: release/3.0-preview9
- dependsOn: NetCore_Dev5_PublishValidation
- dependsOn: NetCore_Dev31_Publish_Validation
channel:
name: .NET Core 3.1 Dev
bar: PublicDevRelease_31_Channel_Id
storage: release/3.1
- dependsOn: NetCore_Release31_Publish_Validation
channel:
name: .NET Core 3.1 Release
bar: PublicRelease_31_Channel_Id
storage: release/3.1-preview1
- dependsOn: NetCore_Dev5_Publish_Validation
channel:
name: .NET Core 5 Dev
bar: NetCore_5_Dev_Channel_Id
Expand Down
12 changes: 12 additions & 0 deletions eng/SignCheckExclusionsFile.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
;; Exclusions for SignCheck. Corresponds to info in Signing.props.
;; Format: https://github.com/dotnet/arcade/blob/397316e195639450b6c76bfeb9823b40bee72d6d/src/SignCheck/Microsoft.SignCheck/Verification/Exclusion.cs#L23-L35
;;
;; This issue tracks a way to implement exclusions via Signing.props and avoid this extra file: https://github.com/dotnet/arcade/issues/2888

;; The apphost and comhost are template files, modified by the SDK to produce the executable for FDE
;; and FDD apps. If they are signed, the file that the SDK produces has an invalid signature and
;; can't be signed again. More info at https://github.com/dotnet/core-setup/pull/7549.
*apphost.exe;;Template, https://github.com/dotnet/core-setup/pull/7549
*comhost.dll;;Template, https://github.com/dotnet/core-setup/pull/7549
*apphosttemplateapphostexe.exe;;Template, https://github.com/dotnet/core-setup/pull/7549
*comhosttemplatecomhostdll.dll;;Template, https://github.com/dotnet/core-setup/pull/7549
36 changes: 26 additions & 10 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -117,27 +117,43 @@
<Uri>https://github.com/dotnet/standard</Uri>
<Sha>f3b1db40ac53eab80c96c3cfa784f5c38bb02d4a</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.Runtime.CoreCLR" Version="3.0.0-preview9.19409.2">
<Dependency Name="Microsoft.NETCore.Runtime.CoreCLR" Version="3.0.0-rc1.19430.3">
<Uri>https://github.com/dotnet/coreclr</Uri>
<Sha>eeec95164a0b39ad3f98dfe04012675f30807cb1</Sha>
<Sha>d67367f691e789cf670f48dc646c66e63b804f8d</Sha>
</Dependency>
<Dependency Name="Microsoft.Private.Winforms" Version="4.8.0-preview9.19415.10" CoherentParentDependency="Microsoft.DotNet.Wpf.DncEng">
<Dependency Name="Microsoft.Private.Winforms" Version="4.8.0-preview9.19417.1" CoherentParentDependency="Microsoft.DotNet.Wpf.DncEng">
<Uri>https://github.com/dotnet/winforms</Uri>
<Sha>8b19141d6b0b221167bd7d1731cbc6aa9898da75</Sha>
<Sha>dd6650900f5af7283c6af6ec85de4d8d51f28961</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Wpf.GitHub" Version="4.8.0-preview9.19416.2" CoherentParentDependency="Microsoft.DotNet.Wpf.DncEng">
<Dependency Name="Microsoft.DotNet.Wpf.GitHub" Version="4.8.0-preview9.19417.4" CoherentParentDependency="Microsoft.DotNet.Wpf.DncEng">
<Uri>https://github.com/dotnet/wpf</Uri>
<Sha>105b673bddd8665580a94878db12ac97af8fa794</Sha>
<Sha>ffc3fbd836fb6ff3c28e50fec67be5b55c8b6542</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Wpf.DncEng" Version="4.8.0-preview9.19416.7">
<Dependency Name="Microsoft.DotNet.Wpf.DncEng" Version="5.0.0-alpha1.19420.2">
<Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-wpf-int</Uri>
<Sha>9dbf98944d032f91760e92882c80859cbf45b847</Sha>
<Sha>83ab428ae9904012fbf4f109c2a5026793136966</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19420.8">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="1.0.0-beta.19454.31">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>fa168dd690798a683ef0d1e65d60ce5d6918d987</Sha>
<Sha>00d8aa82b488f321204a0e69a81399af9df276a1</Sha>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Feed" Version="2.2.0-beta.19454.31">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>00d8aa82b488f321204a0e69a81399af9df276a1</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Packaging" Version="1.0.0-beta.19454.31">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>00d8aa82b488f321204a0e69a81399af9df276a1</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.VersionTools.Tasks" Version="1.0.0-beta.19454.31">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>00d8aa82b488f321204a0e69a81399af9df276a1</Sha>
</Dependency>
<Dependency Name="Microsoft.SourceLink" Version="1.0.0-beta2-19367-01">
<Uri>https://github.com/dotnet/sourcelink</Uri>
<Sha>
</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
18 changes: 9 additions & 9 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@
<!--Package versions-->
<PropertyGroup>
<!-- arcade -->
<MicrosoftDotNetBuildTasksPackagingPackageVersion>1.0.0-beta.19308.1</MicrosoftDotNetBuildTasksPackagingPackageVersion>
<MicrosoftDotNetBuildTasksFeedPackageVersion>2.2.0-beta.19410.2</MicrosoftDotNetBuildTasksFeedPackageVersion>
<MicrosoftDotNetVersionToolsTasksPackageVersion>1.0.0-beta.19308.1</MicrosoftDotNetVersionToolsTasksPackageVersion>
<MicrosoftDotNetBuildTasksFeedPackageVersion>2.2.0-beta.19454.31</MicrosoftDotNetBuildTasksFeedPackageVersion>
<MicrosoftDotNetBuildTasksPackagingPackageVersion>1.0.0-beta.19454.31</MicrosoftDotNetBuildTasksPackagingPackageVersion>
<MicrosoftDotNetVersionToolsTasksPackageVersion>1.0.0-beta.19454.31</MicrosoftDotNetVersionToolsTasksPackageVersion>
<!-- sourcelink -->
<MicrosoftSourceLinkVersion>1.0.0-beta2-19367-01</MicrosoftSourceLinkVersion>
<!-- corefx -->
<MicrosoftNETCorePlatformsPackageVersion>3.0.0-rc1.19454.8</MicrosoftNETCorePlatformsPackageVersion>
<MicrosoftNETCoreTargetsPackageVersion>3.1.0-rc1.19454.8</MicrosoftNETCoreTargetsPackageVersion>
Expand Down Expand Up @@ -71,13 +73,13 @@
<!-- standard -->
<NETStandardLibraryPackageVersion>2.1.0-prerelease.19454.4</NETStandardLibraryPackageVersion>
<!-- coreclr -->
<MicrosoftNETCoreRuntimeCoreCLRPackageVersion>3.0.0-preview9.19409.2</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
<MicrosoftNETCoreRuntimeCoreCLRPackageVersion>3.0.0-rc1.19430.3</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
<!-- winforms -->
<MicrosoftPrivateWinformsPackageVersion>4.8.0-preview9.19415.10</MicrosoftPrivateWinformsPackageVersion>
<MicrosoftPrivateWinformsPackageVersion>4.8.0-preview9.19417.1</MicrosoftPrivateWinformsPackageVersion>
<!-- wpf -->
<MicrosoftDotNetWpfGitHubPackageVersion>4.8.0-preview9.19416.2</MicrosoftDotNetWpfGitHubPackageVersion>
<MicrosoftDotNetWpfGitHubPackageVersion>4.8.0-preview9.19417.4</MicrosoftDotNetWpfGitHubPackageVersion>
<!-- wpf-int -->
<MicrosoftDotNetWpfDncEngPackageVersion>4.8.0-preview9.19416.7</MicrosoftDotNetWpfDncEngPackageVersion>
<MicrosoftDotNetWpfDncEngPackageVersion>5.0.0-alpha1.19420.2</MicrosoftDotNetWpfDncEngPackageVersion>
<!-- Not auto-updated. -->
<MicrosoftBuildPackageVersion>15.7.179</MicrosoftBuildPackageVersion>
<MicrosoftBuildFrameworkPackageVersion>$(MicrosoftBuildPackageVersion)</MicrosoftBuildFrameworkPackageVersion>
Expand All @@ -88,8 +90,6 @@
<NugetPackagingPackageVersion>4.9.4</NugetPackagingPackageVersion>
<MicrosoftTargetingPackPrivateWinRTPackageVersion>1.0.5</MicrosoftTargetingPackPrivateWinRTPackageVersion>
<MicrosoftDiaSymReaderNativePackageVersion>1.7.0</MicrosoftDiaSymReaderNativePackageVersion>
<!-- Infrastructure and test-only. -->
<MicrosoftSourceLinkVersion>1.0.0-beta2-18618-05</MicrosoftSourceLinkVersion>
</PropertyGroup>
<!--Package names-->
<PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions eng/common/darc-init.ps1
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
param (
$darcVersion = $null,
$versionEndpoint = "https://maestro-prod.westus2.cloudapp.azure.com/api/assets/darc-version?api-version=2019-01-16"
$versionEndpoint = "https://maestro-prod.westus2.cloudapp.azure.com/api/assets/darc-version?api-version=2019-01-16",
$verbosity = "m"
)

$verbosity = "m"
. $PSScriptRoot\tools.ps1

function InstallDarcCli ($darcVersion) {
Expand Down
6 changes: 5 additions & 1 deletion eng/common/darc-init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
source="${BASH_SOURCE[0]}"
darcVersion=''
versionEndpoint="https://maestro-prod.westus2.cloudapp.azure.com/api/assets/darc-version?api-version=2019-01-16"
verbosity=m

while [[ $# > 0 ]]; do
opt="$(echo "$1" | awk '{print tolower($0)}')"
Expand All @@ -15,6 +16,10 @@ while [[ $# > 0 ]]; do
versionEndpoint=$2
shift
;;
--verbosity)
verbosity=$2
shift
;;
*)
echo "Invalid argument: $1"
usage
Expand All @@ -34,7 +39,6 @@ while [[ -h "$source" ]]; do
[[ $source != /* ]] && source="$scriptroot/$source"
done
scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
verbosity=m

. "$scriptroot/tools.sh"

Expand Down
2 changes: 2 additions & 0 deletions eng/common/native/CommonLibrary.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ function Get-File {
}
else {
Write-Verbose "Downloading $Uri"
# Don't display the console progress UI - it's a huge perf hit
$ProgressPreference = 'SilentlyContinue'
while($Attempt -Lt $DownloadRetries)
{
try {
Expand Down
29 changes: 27 additions & 2 deletions eng/common/performance/perfhelixpublish.proj
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,14 @@
<CliArguments>--dotnet-versions %DOTNET_VERSION% --cli-source-info args --cli-branch %PERFLAB_BRANCH% --cli-commit-sha %PERFLAB_HASH% --cli-repository https://github.com/%PERFLAB_REPO% --cli-source-timestamp %PERFLAB_BUILDTIMESTAMP%</CliArguments>
<Python>py -3</Python>
<CoreRun>%HELIX_CORRELATION_PAYLOAD%\Core_Root\CoreRun.exe</CoreRun>
<BaselineCoreRun>%HELIX_CORRELATION_PAYLOAD%\Baseline_Core_Root\CoreRun.exe</BaselineCoreRun>
<HelixPreCommands>$(HelixPreCommands);call %HELIX_CORRELATION_PAYLOAD%\performance\tools\machine-setup.cmd</HelixPreCommands>
<ArtifactsDirectory>%HELIX_CORRELATION_PAYLOAD%\artifacts\BenchmarkDotNet.Artifacts</ArtifactsDirectory>
<BaselineArtifactsDirectory>%HELIX_CORRELATION_PAYLOAD%\artifacts\BenchmarkDotNet.Artifacts_Baseline</BaselineArtifactsDirectory>
<ResultsComparer>%HELIX_CORRELATION_PAYLOAD%\performance\src\tools\ResultsComparer\ResultsComparer.csproj</ResultsComparer>
<DotnetExe>%HELIX_CORRELATION_PAYLOAD%\performance\tools\dotnet\$(Architecture)\dotnet.exe</DotnetExe>
<Percent>%25%25</Percent>
<XMLResults>%HELIX_WORKITEM_ROOT%\testResults.xml</XMLResults>
</PropertyGroup>

<PropertyGroup Condition="'$(AGENT_OS)' != 'Windows_NT' and '$(RunFromPerfRepo)' == 'false'">
Expand All @@ -24,14 +30,24 @@
<CliArguments>--dotnet-versions $DOTNET_VERSION --cli-source-info args --cli-branch $PERFLAB_BRANCH --cli-commit-sha $PERFLAB_HASH --cli-repository https://github.com/$PERFLAB_REPO --cli-source-timestamp $PERFLAB_BUILDTIMESTAMP</CliArguments>
<Python>python3</Python>
<CoreRun>$(BaseDirectory)/Core_Root/corerun</CoreRun>
<BaselineCoreRun>$(BaseDirectory)/Baseline_Core_Root/corerun</BaselineCoreRun>
<HelixPreCommands>$(HelixPreCommands);chmod +x $(PerformanceDirectory)/tools/machine-setup.sh;. $(PerformanceDirectory)/tools/machine-setup.sh</HelixPreCommands>
<ArtifactsDirectory>$(BaseDirectory)/artifacts/BenchmarkDotNet.Artifacts</ArtifactsDirectory>
<BaselineArtifactsDirectory>$(BaseDirectory)/artifacts/BenchmarkDotNet.Artifacts_Baseline</BaselineArtifactsDirectory>
<ResultsComparer>$(PerformanceDirectory)/src/tools/ResultsComparer/ResultsComparer.csproj</ResultsComparer>
<DotnetExe>$(PerformanceDirectory)/tools/dotnet/$(Architecture)/dotnet</DotnetExe>
<Percent>%25</Percent>
<XMLResults>$HELIX_WORKITEM_ROOT/testResults.xml</XMLResults>
</PropertyGroup>

<PropertyGroup Condition="'$(UseCoreRun)' == 'true'">
<CoreRunArgument>--corerun $(CoreRun)</CoreRunArgument>
</PropertyGroup>

<PropertyGroup Condition="'$(UseBaselineCoreRun)' == 'true'">
<BaselineCoreRunArgument>--corerun $(BaselineCoreRun)</BaselineCoreRunArgument>
</PropertyGroup>

<PropertyGroup Condition="'$(WorkItemCommand)' != ''">
<WorkItemCommand>$(Python) $(WorkItemCommand) --incremental no --architecture $(Architecture) -f $(_Framework) $(PerfLabArguments)</WorkItemCommand>
</PropertyGroup>
Expand All @@ -57,20 +73,29 @@
<Partition Include="$(BuildConfig).Partition4" Index="4" />
</ItemGroup>

<PropertyGroup Condition="'$(Compare)' == 'true'">
<FailOnTestFailure>false</FailOnTestFailure>
</PropertyGroup>

<!--
Partition the Microbenchmarks project, but nothing else
-->
<ItemGroup Condition="$(TargetCsproj.Contains('MicroBenchmarks.csproj'))">
<HelixWorkItem Include="@(Partition)">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<Command>$(WorkItemCommand) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(CoreRunArgument) --artifacts $(ArtifactsDirectory) --partition-count $(PartitionCount) --partition-index %(HelixWorkItem.Index)"</Command>
<PreCommands Condition="'$(Compare)' == 'true'">$(WorkItemCommand) --bdn-artifacts $(BaselineArtifactsDirectory) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(BaselineCoreRunArgument) --partition-count $(PartitionCount) --partition-index %(HelixWorkItem.Index)"</PreCommands>
<Command>$(WorkItemCommand) --bdn-artifacts $(ArtifactsDirectory) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(CoreRunArgument) --partition-count $(PartitionCount) --partition-index %(HelixWorkItem.Index)"</Command>
<PostCommands Condition="'$(Compare)' == 'true'">$(DotnetExe) run -f $(_Framework) -p $(ResultsComparer) --base $(BaselineArtifactsDirectory) --diff $(ArtifactsDirectory) --threshold 2$(Percent) --xml $(XMLResults);$(FinalCommand)</PostCommands>
<Timeout>4:00</Timeout>
</HelixWorkItem>
</ItemGroup>

<ItemGroup Condition="!$(TargetCsproj.Contains('MicroBenchmarks.csproj'))">
<HelixWorkItem Include="$(BuildConfig).WorkItem">
<PayloadDirectory>$(WorkItemDirectory)</PayloadDirectory>
<Command>$(WorkItemCommand) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(CoreRunArgument) --artifacts $(ArtifactsDirectory)"</Command>
<PreCommands Condition="'$(Compare)' == 'true'">$(WorkItemCommand) --bdn-artifacts $(BaselineArtifactsDirectory) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(BaselineCoreRunArgument)"</PreCommands>
<Command>$(WorkItemCommand) --bdn-artifacts $(ArtifactsDirectory) --bdn-arguments="--anyCategories $(BDNCategories) $(ExtraBenchmarkDotNetArguments) $(CoreRunArgument)"</Command>
<PostCommands Condition="'$(Compare)' == 'true'">$(DotnetExe) run -f $(_Framework) -p $(ResultsComparer) --base $(BaselineArtifactsDirectory) --diff $(ArtifactsDirectory) --threshold 2$(Percent) --xml $(XMLResults)</PostCommands>
<Timeout>4:00</Timeout>
</HelixWorkItem>
</ItemGroup>
Expand Down
17 changes: 16 additions & 1 deletion eng/common/performance/performance-setup.ps1
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Param(
[string] $SourceDirectory=$env:BUILD_SOURCESDIRECTORY,
[string] $CoreRootDirectory,
[string] $BaselineCoreRootDirectory,
[string] $Architecture="x64",
[string] $Framework="netcoreapp5.0",
[string] $CompilationMode="Tiered",
Expand All @@ -12,11 +13,13 @@ Param(
[string] $Csproj="src\benchmarks\micro\MicroBenchmarks.csproj",
[string] $Kind="micro",
[switch] $Internal,
[switch] $Compare,
[string] $Configurations="CompilationMode=$CompilationMode"
)

$RunFromPerformanceRepo = ($Repository -eq "dotnet/performance")
$UseCoreRun = ($CoreRootDirectory -ne [string]::Empty)
$UseBaselineCoreRun = ($BaselineCoreRootDirectory -ne [string]::Empty)

$PayloadDirectory = (Join-Path $SourceDirectory "Payload")
$PerformanceDirectory = (Join-Path $PayloadDirectory "performance")
Expand All @@ -29,7 +32,13 @@ $HelixSourcePrefix = "pr"
$Queue = "Windows.10.Amd64.ClientRS4.DevEx.15.8.Open"

if ($Framework.StartsWith("netcoreapp")) {
$Queue = "Windows.10.Amd64.ClientRS4.Open"
$Queue = "Windows.10.Amd64.ClientRS5.Open"
}

if ($Compare) {
$Queue = "Windows.10.Amd64.19H1.Tiger.Perf.Open"
$PerfLabArguments = ""
$ExtraBenchmarkDotNetArguments = ""
}

if ($Internal) {
Expand All @@ -56,6 +65,10 @@ if ($UseCoreRun) {
$NewCoreRoot = (Join-Path $PayloadDirectory "Core_Root")
Move-Item -Path $CoreRootDirectory -Destination $NewCoreRoot
}
if ($UseBaselineCoreRun) {
$NewBaselineCoreRoot = (Join-Path $PayloadDirectory "Baseline_Core_Root")
Move-Item -Path $BaselineCoreRootDirectory -Destination $NewBaselineCoreRoot
}

$DocsDir = (Join-Path $PerformanceDirectory "docs")
robocopy $DocsDir $WorkItemDirectory
Expand All @@ -80,7 +93,9 @@ Write-PipelineSetVariable -Name 'TargetCsproj' -Value "$Csproj" -IsMultiJobVaria
Write-PipelineSetVariable -Name 'Kind' -Value "$Kind" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'Architecture' -Value "$Architecture" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'UseCoreRun' -Value "$UseCoreRun" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'UseBaselineCoreRun' -Value "$UseBaselineCoreRun" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'RunFromPerfRepo' -Value "$RunFromPerformanceRepo" -IsMultiJobVariable $false
Write-PipelineSetVariable -Name 'Compare' -Value "$Compare" -IsMultiJobVariable $false

# Helix Arguments
Write-PipelineSetVariable -Name 'Creator' -Value "$Creator" -IsMultiJobVariable $false
Expand Down
Loading