-
Notifications
You must be signed in to change notification settings - Fork 4.9k
add api diff for between rc1 and rc2 #5370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # API Difference net5.0-rc1 vs net5.0-rc2 | ||
|
|
||
| API listing follows standard diff formatting. Lines preceded by a '+' are | ||
| additions and a '-' indicates removal. | ||
|
|
||
| * [System.Diagnostics](5.0-rc2_System.Diagnostics.md) | ||
| * [System.Globalization](5.0-rc2_System.Globalization.md) | ||
| * [System.Net](5.0-rc2_System.Net.md) | ||
| * [System.Net.Connections](5.0-rc2_System.Net.Connections.md) | ||
| * [System.Net.Http](5.0-rc2_System.Net.Http.md) | ||
|
|
||
11 changes: 11 additions & 0 deletions
11
release-notes/5.0/preview/api-diff/rc2/.Net/5.0-rc2_System.Diagnostics.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # System.Diagnostics | ||
|
|
||
| ``` diff | ||
| namespace System.Diagnostics { | ||
| public readonly struct ActivityContext : IEquatable<ActivityContext> { | ||
| - public ActivityContext(ActivityTraceId traceId, ActivitySpanId spanId, ActivityTraceFlags traceOptions, string traceState = null, bool isRemote = false); | ||
| + public ActivityContext(ActivityTraceId traceId, ActivitySpanId spanId, ActivityTraceFlags traceFlags, string traceState = null, bool isRemote = false); | ||
| } | ||
| } | ||
| ``` | ||
|
|
11 changes: 11 additions & 0 deletions
11
release-notes/5.0/preview/api-diff/rc2/.Net/5.0-rc2_System.Globalization.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # System.Globalization | ||
|
|
||
| ``` diff | ||
| namespace System.Globalization { | ||
| public sealed class CompareInfo : IDeserializationCallback { | ||
| - public bool IsPrefix(ReadOnlySpan<char> source, ReadOnlySpan<char> suffix, CompareOptions options, out int matchLength); | ||
| + public bool IsPrefix(ReadOnlySpan<char> source, ReadOnlySpan<char> prefix, CompareOptions options, out int matchLength); | ||
| } | ||
| } | ||
| ``` | ||
|
|
125 changes: 125 additions & 0 deletions
125
release-notes/5.0/preview/api-diff/rc2/.Net/5.0-rc2_System.Net.Connections.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| # System.Net.Connections | ||
|
|
||
| ``` diff | ||
| -namespace System.Net.Connections { | ||
| { | ||
| - public abstract class Connection : ConnectionBase { | ||
| { | ||
| - protected Connection(); | ||
|
|
||
| - public IDuplexPipe Pipe { get; } | ||
|
|
||
| - public Stream Stream { get; } | ||
|
|
||
| - protected virtual IDuplexPipe CreatePipe(); | ||
|
|
||
| - protected virtual Stream CreateStream(); | ||
|
|
||
| - public static Connection FromPipe(IDuplexPipe pipe, bool leaveOpen = false, IConnectionProperties properties = null, EndPoint localEndPoint = null, EndPoint remoteEndPoint = null); | ||
|
|
||
| - public static Connection FromStream(Stream stream, bool leaveOpen = false, IConnectionProperties properties = null, EndPoint localEndPoint = null, EndPoint remoteEndPoint = null); | ||
|
|
||
| - } | ||
| - public abstract class ConnectionBase : IAsyncDisposable, IDisposable { | ||
| { | ||
| - protected ConnectionBase(); | ||
|
|
||
| - public abstract IConnectionProperties ConnectionProperties { get; } | ||
|
|
||
| - public abstract EndPoint LocalEndPoint { get; } | ||
|
|
||
| - public abstract EndPoint RemoteEndPoint { get; } | ||
|
|
||
| - public ValueTask CloseAsync(ConnectionCloseMethod method = ConnectionCloseMethod.GracefulShutdown, CancellationToken cancellationToken = default(CancellationToken)); | ||
|
|
||
| - protected abstract ValueTask CloseAsyncCore(ConnectionCloseMethod method, CancellationToken cancellationToken); | ||
|
|
||
| - public void Dispose(); | ||
|
|
||
| - public ValueTask DisposeAsync(); | ||
|
|
||
| - } | ||
| - public enum ConnectionCloseMethod { | ||
| { | ||
| - Abort = 1, | ||
|
|
||
| - GracefulShutdown = 0, | ||
|
|
||
| - Immediate = 2, | ||
|
|
||
| - } | ||
| - public static class ConnectionExtensions { | ||
| { | ||
| - public static ConnectionFactory Filter(this ConnectionFactory factory, Func<Connection, IConnectionProperties, CancellationToken, ValueTask<Connection>> filter); | ||
|
|
||
| - public static bool TryGet<T>(this IConnectionProperties properties, out T property); | ||
|
|
||
| - } | ||
| - public abstract class ConnectionFactory : IAsyncDisposable, IDisposable { | ||
| { | ||
| - protected ConnectionFactory(); | ||
|
|
||
| - public abstract ValueTask<Connection> ConnectAsync(EndPoint endPoint, IConnectionProperties options = null, CancellationToken cancellationToken = default(CancellationToken)); | ||
|
|
||
| - public void Dispose(); | ||
|
|
||
| - protected virtual void Dispose(bool disposing); | ||
|
|
||
| - public ValueTask DisposeAsync(); | ||
|
|
||
| - protected virtual ValueTask DisposeAsyncCore(); | ||
|
|
||
| - } | ||
| - public abstract class ConnectionListener : IAsyncDisposable, IDisposable { | ||
| { | ||
| - protected ConnectionListener(); | ||
|
|
||
| - public abstract IConnectionProperties ListenerProperties { get; } | ||
|
|
||
| - public abstract EndPoint LocalEndPoint { get; } | ||
|
|
||
| - public abstract ValueTask<Connection> AcceptAsync(IConnectionProperties options = null, CancellationToken cancellationToken = default(CancellationToken)); | ||
|
|
||
| - public void Dispose(); | ||
|
|
||
| - protected virtual void Dispose(bool disposing); | ||
|
|
||
| - public ValueTask DisposeAsync(); | ||
|
|
||
| - protected virtual ValueTask DisposeAsyncCore(); | ||
|
|
||
| - } | ||
| - public abstract class ConnectionListenerFactory : IAsyncDisposable, IDisposable { | ||
| { | ||
| - protected ConnectionListenerFactory(); | ||
|
|
||
| - public void Dispose(); | ||
|
|
||
| - protected virtual void Dispose(bool disposing); | ||
|
|
||
| - public ValueTask DisposeAsync(); | ||
|
|
||
| - protected virtual ValueTask DisposeAsyncCore(); | ||
|
|
||
| - public abstract ValueTask<ConnectionListener> ListenAsync(EndPoint endPoint, IConnectionProperties options = null, CancellationToken cancellationToken = default(CancellationToken)); | ||
|
|
||
| - } | ||
| - public interface IConnectionProperties { | ||
| { | ||
| - bool TryGet(Type propertyKey, out object property); | ||
|
|
||
| - } | ||
| - public class SocketsConnectionFactory : ConnectionFactory { | ||
| { | ||
| - public SocketsConnectionFactory(AddressFamily addressFamily, SocketType socketType, ProtocolType protocolType); | ||
|
|
||
| - public SocketsConnectionFactory(SocketType socketType, ProtocolType protocolType); | ||
|
|
||
| - public override ValueTask<Connection> ConnectAsync(EndPoint endPoint, IConnectionProperties options = null, CancellationToken cancellationToken = default(CancellationToken)); | ||
|
|
||
| - protected virtual Socket CreateSocket(AddressFamily addressFamily, SocketType socketType, ProtocolType protocolType, EndPoint endPoint, IConnectionProperties options); | ||
|
|
||
| - } | ||
| -} | ||
| ``` | ||
|
|
24 changes: 24 additions & 0 deletions
24
release-notes/5.0/preview/api-diff/rc2/.Net/5.0-rc2_System.Net.Http.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # System.Net.Http | ||
|
|
||
| ``` diff | ||
| namespace System.Net.Http { | ||
| + public sealed class SocketsHttpConnectionContext { | ||
| + public DnsEndPoint DnsEndPoint { get; } | ||
| + public HttpRequestMessage InitialRequestMessage { get; } | ||
| + } | ||
| public sealed class SocketsHttpHandler : HttpMessageHandler { | ||
| + public Func<SocketsHttpConnectionContext, CancellationToken, ValueTask<Stream>> ConnectCallback { get; set; } | ||
| - public ConnectionFactory ConnectionFactory { get; set; } | ||
|
|
||
| - public Func<HttpRequestMessage, Connection, CancellationToken, ValueTask<Connection>> PlaintextFilter { get; set; } | ||
|
|
||
| + public Func<SocketsHttpPlaintextStreamFilterContext, CancellationToken, ValueTask<Stream>> PlaintextStreamFilter { get; set; } | ||
| } | ||
| + public sealed class SocketsHttpPlaintextStreamFilterContext { | ||
| + public HttpRequestMessage InitialRequestMessage { get; } | ||
| + public Version NegotiatedHttpVersion { get; } | ||
| + public Stream PlaintextStream { get; } | ||
| + } | ||
| } | ||
| ``` | ||
|
|
37 changes: 37 additions & 0 deletions
37
release-notes/5.0/preview/api-diff/rc2/.Net/5.0-rc2_System.Net.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # System.Net | ||
|
|
||
| ``` diff | ||
| namespace System.Net { | ||
| - public enum NetworkError { | ||
| { | ||
| - ConnectionAborted = 6, | ||
|
|
||
| - ConnectionRefused = 4, | ||
|
|
||
| - ConnectionReset = 7, | ||
|
|
||
| - EndPointInUse = 1, | ||
|
|
||
| - HostNotFound = 2, | ||
|
|
||
| - OperationAborted = 5, | ||
|
|
||
| - Other = 0, | ||
|
|
||
| - TimedOut = 3, | ||
|
|
||
| - } | ||
| - public class NetworkException : IOException { | ||
| { | ||
| - public NetworkException(NetworkError error, Exception innerException = null); | ||
|
|
||
| - protected NetworkException(SerializationInfo serializationInfo, StreamingContext streamingContext); | ||
|
|
||
| - public NetworkException(string message, NetworkError error, Exception innerException = null); | ||
|
|
||
| - public NetworkError NetworkError { get; } | ||
|
|
||
| - } | ||
| } | ||
| ``` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # API Difference net5.0-rc1 vs net5.0-rc2 | ||
|
|
||
| API listing follows standard diff formatting. Lines preceded by a '+' are | ||
| additions and a '-' indicates removal. | ||
|
|
||
| * [Microsoft.AspNetCore.Builder](5.0-rc2_Microsoft.AspNetCore.Builder.md) | ||
| * [Microsoft.AspNetCore.Components.Server.ProtectedBrowserStorage](5.0-rc2_Microsoft.AspNetCore.Components.Server.ProtectedBrowserStorage.md) | ||
| * [Microsoft.AspNetCore.Components.Web.Virtualization](5.0-rc2_Microsoft.AspNetCore.Components.Web.Virtualization.md) | ||
| * [Microsoft.JSInterop](5.0-rc2_Microsoft.JSInterop.md) | ||
| * [Microsoft.JSInterop.Implementation](5.0-rc2_Microsoft.JSInterop.Implementation.md) | ||
|
|
13 changes: 13 additions & 0 deletions
13
...-notes/5.0/preview/api-diff/rc2/Asp.Net/5.0-rc2_Microsoft.AspNetCore.Builder.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Microsoft.AspNetCore.Builder | ||
|
|
||
| ``` diff | ||
| namespace Microsoft.AspNetCore.Builder { | ||
| public static class ControllerEndpointRouteBuilderExtensions { | ||
| + public static void MapDynamicControllerRoute<TTransformer>(this IEndpointRouteBuilder endpoints, string pattern, object state, int order) where TTransformer : DynamicRouteValueTransformer; | ||
| } | ||
| public static class RazorPagesEndpointRouteBuilderExtensions { | ||
| + public static void MapDynamicPageRoute<TTransformer>(this IEndpointRouteBuilder endpoints, string pattern, object state, int order) where TTransformer : DynamicRouteValueTransformer; | ||
| } | ||
| } | ||
| ``` | ||
|
|
24 changes: 24 additions & 0 deletions
24
...p.Net/5.0-rc2_Microsoft.AspNetCore.Components.Server.ProtectedBrowserStorage.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Microsoft.AspNetCore.Components.Server.ProtectedBrowserStorage | ||
|
|
||
| ``` diff | ||
| +namespace Microsoft.AspNetCore.Components.Server.ProtectedBrowserStorage { | ||
| + public abstract class ProtectedBrowserStorage { | ||
| + public ValueTask DeleteAsync(string key); | ||
| + public ValueTask<ProtectedBrowserStorageResult<TValue>> GetAsync<TValue>(string key); | ||
| + public ValueTask<ProtectedBrowserStorageResult<TValue>> GetAsync<TValue>(string purpose, string key); | ||
| + public ValueTask SetAsync(string key, object value); | ||
| + public ValueTask SetAsync(string purpose, string key, object value); | ||
| + } | ||
| + public readonly struct ProtectedBrowserStorageResult<TValue> { | ||
| + public bool Success { get; } | ||
| + public TValue Value { get; } | ||
| + } | ||
| + public sealed class ProtectedLocalStorage : ProtectedBrowserStorage { | ||
| + public ProtectedLocalStorage(IJSRuntime jsRuntime, IDataProtectionProvider dataProtectionProvider); | ||
| + } | ||
| + public sealed class ProtectedSessionStorage : ProtectedBrowserStorage { | ||
| + public ProtectedSessionStorage(IJSRuntime jsRuntime, IDataProtectionProvider dataProtectionProvider); | ||
| + } | ||
| +} | ||
| ``` | ||
|
|
11 changes: 11 additions & 0 deletions
11
...-diff/rc2/Asp.Net/5.0-rc2_Microsoft.AspNetCore.Components.Web.Virtualization.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Microsoft.AspNetCore.Components.Web.Virtualization | ||
|
|
||
| ``` diff | ||
| namespace Microsoft.AspNetCore.Components.Web.Virtualization { | ||
| public sealed class Virtualize<TItem> : ComponentBase, IAsyncDisposable, IVirtualizeJsCallbacks { | ||
| + public int OverscanCount { get; set; } | ||
| + public Task RefreshDataAsync(); | ||
| } | ||
| } | ||
| ``` | ||
|
|
20 changes: 20 additions & 0 deletions
20
.../5.0/preview/api-diff/rc2/Asp.Net/5.0-rc2_Microsoft.JSInterop.Implementation.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Microsoft.JSInterop.Implementation | ||
|
|
||
| ``` diff | ||
| +namespace Microsoft.JSInterop.Implementation { | ||
| + public class JSInProcessObjectReference : JSObjectReference, IAsyncDisposable, IDisposable, IJSInProcessObjectReference, IJSObjectReference { | ||
| + protected internal JSInProcessObjectReference(JSInProcessRuntime jsRuntime, long id); | ||
| + public void Dispose(); | ||
| + public TValue Invoke<TValue>(string identifier, params object[] args); | ||
| + } | ||
| + public class JSObjectReference : IAsyncDisposable, IJSObjectReference { | ||
| + protected internal JSObjectReference(JSRuntime jsRuntime, long id); | ||
| + protected internal long Id { get; } | ||
| + public ValueTask DisposeAsync(); | ||
| + public ValueTask<TValue> InvokeAsync<TValue>(string identifier, object[] args); | ||
| + public ValueTask<TValue> InvokeAsync<TValue>(string identifier, CancellationToken cancellationToken, object[] args); | ||
| + protected void ThrowIfDisposed(); | ||
| + } | ||
| +} | ||
| ``` | ||
|
|
58 changes: 58 additions & 0 deletions
58
release-notes/5.0/preview/api-diff/rc2/Asp.Net/5.0-rc2_Microsoft.JSInterop.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Microsoft.JSInterop | ||
|
|
||
| ``` diff | ||
| namespace Microsoft.JSInterop { | ||
| + public interface IJSInProcessObjectReference : IAsyncDisposable, IDisposable, IJSObjectReference { | ||
| + TValue Invoke<TValue>(string identifier, params object[] args); | ||
| + } | ||
| public interface IJSInProcessRuntime : IJSRuntime { | ||
| - T Invoke<T>(string identifier, params object[] args); | ||
|
|
||
| + TResult Invoke<TResult>(string identifier, params object[] args); | ||
| } | ||
| + public interface IJSObjectReference : IAsyncDisposable { | ||
| + ValueTask<TValue> InvokeAsync<TValue>(string identifier, object[] args); | ||
| + ValueTask<TValue> InvokeAsync<TValue>(string identifier, CancellationToken cancellationToken, object[] args); | ||
| + } | ||
| + public interface IJSUnmarshalledObjectReference : IAsyncDisposable, IDisposable, IJSInProcessObjectReference, IJSObjectReference { | ||
| + TResult InvokeUnmarshalled<T0, T1, T2, TResult>(string identifier, T0 arg0, T1 arg1, T2 arg2); | ||
| + TResult InvokeUnmarshalled<T0, T1, TResult>(string identifier, T0 arg0, T1 arg1); | ||
| + TResult InvokeUnmarshalled<T0, TResult>(string identifier, T0 arg0); | ||
| + TResult InvokeUnmarshalled<TResult>(string identifier); | ||
| + } | ||
| - public class JSInProcessObjectReference : JSObjectReference { | ||
| { | ||
| - public TValue Invoke<TValue>(string identifier, params object[] args); | ||
|
|
||
| - } | ||
| + public static class JSInProcessObjectReferenceExtensions { | ||
| + public static void InvokeVoid(this IJSInProcessObjectReference jsObjectReference, string identifier, params object[] args); | ||
| + } | ||
| - public class JSObjectReference : IAsyncDisposable { | ||
| { | ||
| - public ValueTask DisposeAsync(); | ||
|
|
||
| - public ValueTask<TValue> InvokeAsync<TValue>(string identifier, params object[] args); | ||
|
|
||
| - public ValueTask<TValue> InvokeAsync<TValue>(string identifier, CancellationToken cancellationToken, params object[] args); | ||
|
|
||
| - public ValueTask InvokeVoidAsync(string identifier, params object[] args); | ||
|
|
||
| - protected void ThrowIfDisposed(); | ||
|
|
||
| - } | ||
| + public static class JSObjectReferenceExtensions { | ||
| + public static ValueTask<TValue> InvokeAsync<TValue>(this IJSObjectReference jsObjectReference, string identifier, params object[] args); | ||
| + public static ValueTask<TValue> InvokeAsync<TValue>(this IJSObjectReference jsObjectReference, string identifier, CancellationToken cancellationToken, params object[] args); | ||
| + public static ValueTask<TValue> InvokeAsync<TValue>(this IJSObjectReference jsObjectReference, string identifier, TimeSpan timeout, params object[] args); | ||
| + public static ValueTask InvokeVoidAsync(this IJSObjectReference jsObjectReference, string identifier, params object[] args); | ||
| + public static ValueTask InvokeVoidAsync(this IJSObjectReference jsObjectReference, string identifier, CancellationToken cancellationToken, params object[] args); | ||
| + public static ValueTask InvokeVoidAsync(this IJSObjectReference jsObjectReference, string identifier, TimeSpan timeout, params object[] args); | ||
| + } | ||
| public abstract class JSRuntime : IJSRuntime { | ||
| - protected static JSCallResultType ResultTypeFromGeneric<TResult>(); | ||
|
|
||
| } | ||
| } | ||
| ``` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # .NET 5.0 rc2 API Changes | ||
|
|
||
| The following API changes were made in .NET 5.0 Preview 8: | ||
|
|
||
| - [.NET](./.Net/5.0-rc2.md) | ||
| - [ASP.NET](./Asp.Net/5.0-rc2.md) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipelines isn't mentioned in the summary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the pipelines changes between RC1 and RC2 because its basically a wash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was removed from the shared framework, is that worth mentioning?