This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add some tests for invalid inputs to MemberAccess expressions - #10940
Merged
Conversation
| public static MemberExpression Field(Expression expression, string fieldName) | ||
| { | ||
| RequiresCanRead(expression, nameof(expression)); | ||
| ContractUtils.RequiresNotNull(fieldName, nameof(fieldName)); |
Member
There was a problem hiding this comment.
Is this changing an exception type / message / parameter name / etc. that's getting thrown?
Author
There was a problem hiding this comment.
This changes the parameter name only. Without it you get the same exception but an empty Parm name - I put it in here to be consistent with Property that checks before calling Type.GetProperty
Member
|
Thanks. LGTM. cc: @VSadov |
Author
|
@stephentoub I've also just added a new test, but had to rebase to add a dependency in the tests on System.Reflection.Emit, sorry if this means you need to re-review, but the commits are the same Let's hope this doesn't cause merge conflict hell |
Member
|
Thanks, Hugh. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…/corefx#10940) * Add some tests for invalid inputs to MemberAccess expressions * Address PR feedback * Add test for no accessors in ProperyInfo Commit migrated from dotnet/corefx@258b51d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1198
/cc @stephentoub