This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Cleanup and add some CreditCardAttribute tests - #10993
Merged
Merged
Conversation
| attribute.ErrorMessage = null; // note: this overrides the default value | ||
| attribute.ErrorMessage = message; | ||
| attribute.ErrorMessageResourceName = resourceName; | ||
| attribute.ErrorMessageResourceType = resourceType; |
Member
There was a problem hiding this comment.
I'm not sure this is actually testing the same thing as was there previously. Setting these to null isn't the same as not setting them, e.g.
Member
|
Other than my one comment, LGTM. Thanks for the cleanup. |
Member
|
Test Innerloop CentOS7.1 Debug Build and Test please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.