This repository was archived by the owner on Jan 23, 2023. It is now read-only.
RegistryKey: Flesh out tests - #11006
Merged
Merged
Conversation
RegistryKey's name fix-up implementation uses a mark-and-sweep
approach. If there are multiple slashes, any extra slash chars will be
replaced with a marker char ('\uffff'), and then all '\uffff' chars
will be removed, including any pre-existing '\uffff' chars.
If there aren't multiple slashes, any '\uffff' chars should remain.
This commit adds new tests to pin this behavior.
Member
|
LGTM. Thanks for adding these, Justin. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
RegistryKey: Flesh out tests Commit migrated from dotnet/corefx@2b3220d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegistryKey's sub key name fix-up implementation uses a mark-and-sweep approach. If there are multiple slashes, any extra slash chars will be replaced with a marker char ('\uffff'), and then all'\uffff'chars will be removed, including any pre-existing'\uffff'chars.If there aren't multiple slashes, any
'\uffff'chars should remain.This commit adds new tests to pin this behavior.
This behavior isn't documented AFAICT, but I assume we want to maintain it for compatibility sake. (I was looking into improving perf of the fix-up implementation for the common case of names that don't need to be fixed-up, which is why this extra coverage is useful).
cc: @stephentoub