This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update IO test for new Wildcard chars - #17657
Merged
Merged
Conversation
This test has been disabled since the new Wildcard characters were allowed. This PR re-enables them and handles the new characters.
JeremyKuhne
suggested changes
Mar 29, 2017
JeremyKuhne
left a comment
JeremyKuhne
left a comment
Member
There was a problem hiding this comment.
This will fail on the desktop run (where the change doesn't exist)- we need to condition appropriately.
Contributor
Author
Yeah, we've got a bunch of failing IO tests for netfx. I'm making a pass through them in another PR so this one isn't too messy. |
stephentoub
approved these changes
Mar 29, 2017
JeremyKuhne
approved these changes
Mar 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has been disabled since the new Wildcard characters were allowed. This PR re-enables them and handles the new characters.
source was modified in #8669. Tests were disabled in #11585.
Resolves https://github.com/dotnet/corefx/issues/11584
cc: @JeremyKuhne