Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Remove all alpine RIDs from the graph. - #18948

Merged
stephentoub merged 1 commit into
dotnet:masterfrom
mellinoe:remove-alpine-rid
Apr 26, 2017
Merged

Remove all alpine RIDs from the graph.#18948
stephentoub merged 1 commit into
dotnet:masterfrom
mellinoe:remove-alpine-rid

Conversation

@mellinoe

Copy link
Copy Markdown
Contributor

We are not supporting this RID in .NET Core 2.0, and we have never shipped a package which lists this RID. If we want to support this in the future and ship packages for it, we can add it back at that time, with more care taken as to its parents in the graph.

@weshaggard @tmds

Fixes #17430.

@weshaggard

Copy link
Copy Markdown
Member

FYI @ericstj

@weshaggard weshaggard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send this to shiproom and get it into release/2.0.0 branch.

@ericstj

ericstj commented Apr 26, 2017

Copy link
Copy Markdown
Member

This LGTM. We should make sure the community knows that they can add this themselves. If they would like to do so they could create a single package (perhaps in CoreFxLab?) that defines the RID graph for new platforms. So long as projects / other packages reference it they can use the mappings.

@stephentoub
stephentoub merged commit 3f32bdc into dotnet:master Apr 26, 2017
@karelz karelz modified the milestone: 2.0.0 Apr 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants