This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix failing HttpListener tests - #19579
Merged
Merged
Conversation
- Add_InvalidPrefixNotStarted_ThrowsHttpListenerExceptionOnStart: connecting to "http://microsoft.com/" was seemingly allowed in CI. - Add_InvalidPrefixAlreadyStarted_ThrowsHttpListenerExceptionOnAdd: connecting to "http://microsoft.com/" was seemingly allowed in CI. - Remove_PrefixExistsNotStarted_ReturnsTrue: this test shouldn't fail in CI, I reckon it was just disabled alongside the actual bad test (Remove_PrefixExistsStarted_ReturnsTrue) - Remove_PrefixExistsStarted_ReturnsTrue: a race condition: listener may not have actually stopped listening by the time we try to connect.
|
@hughbe looks like this may have fixed it for everything but OSX. |
Author
|
Hmm, maybe I'm just being nervous after breaking the CI yesterday, but I don't really understand why that test would fail, and we can start listening to |
|
We need to purchase you a mac :) |
Author
I wish! :D (I opened an issue. I can try setting up a mac VM, I'm sure there are tutorials online) |
Member
|
@dotnet-bot test this please |
stephentoub
approved these changes
May 10, 2017
Member
|
@dotnet-bot test Innerloop netfx Windows_NT Release x64 Build and Test please |
dotnet-maestro-bot
pushed a commit
to dotnet-maestro-bot/corefx
that referenced
this pull request
Aug 23, 2018
…rmute4x64 for float, double overloads Fixes dotnet#19579 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
that referenced
this pull request
Aug 23, 2018
…rmute4x64 for float, double overloads Fixes #19579 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add_InvalidPrefixNotStarted_ThrowsHttpListenerExceptionOnStart: connecting to "http://microsoft.com/" was seemingly allowed in CI.
Add_InvalidPrefixAlreadyStarted_ThrowsHttpListenerExceptionOnAdd: connecting to "http://microsoft.com/" was seemingly allowed in CI.
Remove_PrefixExistsNotStarted_ReturnsTrue: this test shouldn't fail in CI, I reckon it was just disabled alongside the actual bad test (Remove_PrefixExistsStarted_ReturnsTrue)
Remove_PrefixExistsStarted_ReturnsTrue: a race condition: listener may not have actually stopped listening by the time we try to connect.
Fixes #19526