This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enabled XmlSerializer to Serialize XElement on UWP. - #19843
Merged
Conversation
huanwu
approved these changes
May 18, 2017
Contributor
Author
|
@krwq can you please take a look at the PR? The fix is in |
krwq
approved these changes
May 18, 2017
krwq
left a comment
krwq
left a comment
Member
There was a problem hiding this comment.
Looks good to me - @weshaggard @ericstj could you take a look if this is OK to make XElement public on UAP?
sepidehkh
approved these changes
May 18, 2017
Member
|
If you're going to do this you better leave a comment for the reasoning. |
shmao
force-pushed
the
19809-XElementOnUwp
branch
from
May 19, 2017 00:40
be38df0 to
d2e6d4b
Compare
Contributor
Author
|
Sounds good. I added comments for the ifdef. Besides, I removed System.Private.Xml.Linq.rd.xml, which was for XElement only. After the fix, the rd.xml is not needed. /cc: @vitek-karas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR #19244,
XmlSerializerfailed to serializeXElementon UWP because the metadata info forXElement..ctor()was reduced by UWP toolchain. Although we already have rd.xml for keeping the constructor, see System.Private.Xml.Linq.rd.xml, it didn't work because the assembly hasBlockReflectionAttributeand UWP toolchain would remove metadata for any non-public types/members in the assembly.The fix is to make the constructor public on
uap.Fix #19809.