This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix GetFolderPath test for nano#19948
Merged
Merged
Conversation
joperezr
approved these changes
May 18, 2017
stephentoub
reviewed
May 18, 2017
| { | ||
| // See Nano comment below | ||
| Assert.NotEmpty(knownFolder); | ||
| } |
Member
There was a problem hiding this comment.
At this point, what is the test actually validating on Nano? Should the test just be disabled for it with an attribute?
Member
Author
There was a problem hiding this comment.
Marginal, but it'll flag if SHGetFolderPath and ShGetKnownFolderPath start to diverge....
stephentoub
approved these changes
May 18, 2017
danmoseley
added a commit
to danmoseley/corefx
that referenced
this pull request
May 22, 2017
stephentoub
pushed a commit
that referenced
this pull request
May 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed a line when fixing this before -- since I haven't figured out yet how to run tests on Nano directly, I was pasting in a similar program.
Fixes https://github.com/dotnet/corefx/issues/19110 (which lists off all the API results and shows that Nano produces empty for many of them)