Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Port 2.0: Prep tests for CoreCLR/CoreRT [Serializable] cleanup (#20035) - #20210

Closed
morganbr wants to merge 1 commit into
dotnet:release/2.0.0from
morganbr:PortSerializationTestFixes
Closed

Port 2.0: Prep tests for CoreCLR/CoreRT [Serializable] cleanup (#20035)#20210
morganbr wants to merge 1 commit into
dotnet:release/2.0.0from
morganbr:PortSerializationTestFixes

Conversation

@morganbr

Copy link
Copy Markdown

2.0 port of #20035 Fixes tests that depend on types in System.Private.CoreLib being serializable that won't be serializable soon.

Fixes https://github.com/dotnet/corefx/issues/20041.

Fixes tests that depend on types in System.Private.CoreLib being serializable that won't be serializable soon.
@morganbr

Copy link
Copy Markdown
Author

CC @danmosemsft @tarekgh @dotnet/corert-contrib

@morganbr morganbr self-assigned this May 24, 2017
@morganbr morganbr added this to the 2.0.0 milestone May 24, 2017
@tarekgh

tarekgh commented May 24, 2017

Copy link
Copy Markdown
Member

LGTM. Thanks @morganbr

@danmoseley danmoseley added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label May 24, 2017
@danmoseley

Copy link
Copy Markdown

Let's gather all changes and talk to shiproom before merging.

@karelz karelz added area-Serialization blocked Issue/PR is blocked on something - see comments area-Meta and removed area-Serialization labels May 24, 2017
@tarekgh

tarekgh commented May 24, 2017

Copy link
Copy Markdown
Member

Let's gather all changes and talk to shiproom before merging.

Is this will be done through the email or there is scheduled meeting for it?

@danmoseley

Copy link
Copy Markdown

Is this will be done through the email or there is scheduled meeting for it?

We are doing shiproom by email this week. We may end up going to shiproom physically on Thursday given the size of the change. We will have to explain that we will need to synchronize changes back and forth between coreclr and corefx which may take a couple days.

@tarekgh

tarekgh commented May 25, 2017

Copy link
Copy Markdown
Member

@danmosemsft any update regarding the shiproom?

@danmoseley

Copy link
Copy Markdown

@tarekgh I have a conflict, but I'll send an update mail beforehand. Clearly we can't take it today.

@danmoseley

Copy link
Copy Markdown

@morganbr I guess this is defunct?

@morganbr

morganbr commented Jun 1, 2017

Copy link
Copy Markdown
Author

@danmosemsft yep. I'll close it out.

@morganbr morganbr closed this Jun 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Meta blocked Issue/PR is blocked on something - see comments * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants