Update CoreClr, CoreFx, Standard to preview3-25504-01, preview3-25504-01, preview3-25503-01, respectively (release/2.0.0) - #21734
Conversation
b2288fb to
b5088ec
Compare
a6255e1 to
e4239a8
Compare
e4239a8 to
09e8926
Compare
09e8926 to
ab4f7eb
Compare
75caed5 to
a1cd407
Compare
|
@danmosemsft, several serialization test failures here... |
a1cd407 to
6e707c4
Compare
|
@ViktorHofer for that |
6e707c4 to
a9f82e7
Compare
a9f82e7 to
b87d3fd
Compare
|
On Unix system suddenly CookieContainer serialization behaves differently. The order of the first serialized field is reversed which means that this field appears first in the serialization payload on Unix but last on Windows: https://github.com/dotnet/corefx/blob/master/src/System.Net.Primitives/src/System/Net/CookieContainer.cs#L108 I'm not sure why this is happening now. I need to check recent changes and check the last time it worked. |
|
My guess is that Type.GetFields returns the FieldInfo array in a different order on Unix machines because of a recent change. Investigating and setting up a VM to verify my assumption. |
b87d3fd to
254c4f3
Compare
254c4f3 to
16a0eb4
Compare
16a0eb4 to
d13257f
Compare
d13257f to
89b1024
Compare
89b1024 to
9063dc8
Compare
|
@dotnet/dnceng Innerloop Windows Debug and Release build errors:
|
|
Just to emit all infos which I yet have collected:
Seems to be connected to different return order of Type.GetFields on the mentioned configurations. I now have a Linux box where I try to find the missing piece in the release branch. |
b587c75 to
01e994a
Compare
|
My assumption was wrong. The return order of Type.GetFields is in sync on Unix and Windows. Just tested: Update: |
|
@dotnet-bot test Innerloop Windows_NT Release x64 Build and Test testing something |
01e994a to
3824451
Compare
3824451 to
41c4757
Compare
…-01, preview3-25503-01, respectively
41c4757 to
7b42c84
Compare
|
@dotnet-bot test Innerloop Tizen armel Debug Cross Build |
|
As CI is finally green here I will merge this to unblock the release branch and follow up on the serialization error here: https://github.com/dotnet/corefx/issues/21720 |
No description provided.