Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update CoreClr, CoreFx, Standard to preview3-25504-01, preview3-25504-01, preview3-25503-01, respectively (release/2.0.0) - #21734

Merged
ViktorHofer merged 1 commit into
dotnet:release/2.0.0from
dotnet-maestro-bot:release/2.0.0-UpdateDependencies
Jul 4, 2017
Merged

Update CoreClr, CoreFx, Standard to preview3-25504-01, preview3-25504-01, preview3-25503-01, respectively (release/2.0.0)#21734
ViktorHofer merged 1 commit into
dotnet:release/2.0.0from
dotnet-maestro-bot:release/2.0.0-UpdateDependencies

Conversation

@dotnet-maestro-bot

@dotnet-maestro-bot dotnet-maestro-bot commented Jun 29, 2017

Copy link
Copy Markdown

No description provided.

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr to preview3-25429-02 (release/2.0.0) Update CoreClr, CoreFx to preview3-25429-02, preview3-25430-01, respectively (release/2.0.0) Jun 30, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from b2288fb to b5088ec Compare June 30, 2017 02:02
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx to preview3-25429-02, preview3-25430-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25429-02, preview3-25430-02, preview3-25430-01, respectively (release/2.0.0) Jun 30, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch 2 times, most recently from a6255e1 to e4239a8 Compare June 30, 2017 13:31
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25429-02, preview3-25430-02, preview3-25430-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25429-02, preview3-25501-01, preview3-25430-01, respectively (release/2.0.0) Jul 1, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from e4239a8 to 09e8926 Compare July 1, 2017 01:43
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25429-02, preview3-25501-01, preview3-25430-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25501-01, preview3-25501-01, preview3-25430-01, respectively (release/2.0.0) Jul 1, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from 09e8926 to ab4f7eb Compare July 1, 2017 04:17
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25501-01, preview3-25501-01, preview3-25430-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25501-01, preview3-25501-02, preview3-25501-01, respectively (release/2.0.0) Jul 1, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch 2 times, most recently from 75caed5 to a1cd407 Compare July 1, 2017 13:26
@karelz karelz modified the milestone: 2.0.0 Jul 1, 2017
@stephentoub

stephentoub commented Jul 1, 2017

Copy link
Copy Markdown
Member

@danmosemsft, several serialization test failures here...

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25501-01, preview3-25501-02, preview3-25501-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25501-02, preview3-25501-02, preview3-25501-01, respectively (release/2.0.0) Jul 1, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from a1cd407 to 6e707c4 Compare July 1, 2017 21:12
@danmoseley

Copy link
Copy Markdown

@ViktorHofer for that

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25501-02, preview3-25501-02, preview3-25501-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25501-02, preview3-25502-01, preview3-25501-01, respectively (release/2.0.0) Jul 2, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from 6e707c4 to a9f82e7 Compare July 2, 2017 01:17
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25501-02, preview3-25502-01, preview3-25501-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25502-01, preview3-25502-01, preview3-25501-01, respectively (release/2.0.0) Jul 2, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from a9f82e7 to b87d3fd Compare July 2, 2017 04:03
@ViktorHofer

ViktorHofer commented Jul 2, 2017

Copy link
Copy Markdown
Member

On Unix system suddenly CookieContainer serialization behaves differently. The order of the first serialized field is reversed which means that this field appears first in the serialization payload on Unix but last on Windows: https://github.com/dotnet/corefx/blob/master/src/System.Net.Primitives/src/System/Net/CookieContainer.cs#L108

I'm not sure why this is happening now. I need to check recent changes and check the last time it worked.

@ViktorHofer

Copy link
Copy Markdown
Member

My guess is that Type.GetFields returns the FieldInfo array in a different order on Unix machines because of a recent change. Investigating and setting up a VM to verify my assumption.

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25502-01, preview3-25502-01, preview3-25501-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25502-01, preview3-25502-02, preview3-25501-01, respectively (release/2.0.0) Jul 2, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from b87d3fd to 254c4f3 Compare July 2, 2017 13:12
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25502-01, preview3-25502-02, preview3-25501-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25502-01, preview3-25502-02, preview3-25502-01, respectively (release/2.0.0) Jul 2, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from 254c4f3 to 16a0eb4 Compare July 2, 2017 13:36
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25502-01, preview3-25502-02, preview3-25502-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25502-02, preview3-25502-02, preview3-25502-01, respectively (release/2.0.0) Jul 2, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from 16a0eb4 to d13257f Compare July 2, 2017 21:17
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25502-02, preview3-25502-02, preview3-25502-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25502-02, preview3-25503-01, preview3-25502-01, respectively (release/2.0.0) Jul 3, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from d13257f to 89b1024 Compare July 3, 2017 01:08
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25502-02, preview3-25503-01, preview3-25502-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25503-01, preview3-25503-01, preview3-25502-01, respectively (release/2.0.0) Jul 3, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from 89b1024 to 9063dc8 Compare July 3, 2017 04:10
@ViktorHofer

Copy link
Copy Markdown
Member

@dotnet/dnceng Innerloop Windows Debug and Release build errors:

Installing dotnet cli...
Restoring BuildTools version 2.0.0-prerelease-01616-05...
Initializing BuildTools...
Build timed out (after 120 minutes). Marking the build as aborted.
Build was aborted
https://ci.dot.net/job/dotnet_corefx/job/release_2.0.0/job/windows_nt_release_prtest/401/
https://ci.dot.net/job/dotnet_corefx/job/release_2.0.0/job/windows_nt_debug_prtest/399/

@ViktorHofer

ViktorHofer commented Jul 3, 2017

Copy link
Copy Markdown
Member

Just to emit all infos which I yet have collected:

  1. Occurs only in the release/2.0.0 branch
  2. and only on PortableLinux Debug/Release, Ubuntu 14.04 and CentOS7.1 configurations

Seems to be connected to different return order of Type.GetFields on the mentioned configurations. I now have a Linux box where I try to find the missing piece in the release branch.

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25503-01, preview3-25503-01, preview3-25502-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25503-01, preview3-25503-02, preview3-25503-01, respectively (release/2.0.0) Jul 3, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch 2 times, most recently from b587c75 to 01e994a Compare July 3, 2017 13:29
@ViktorHofer

ViktorHofer commented Jul 3, 2017

Copy link
Copy Markdown
Member

My assumption was wrong. The return order of Type.GetFields is in sync on Unix and Windows. Just tested:

  m_domainTable
  m_maxCookieSize
  m_maxCookies
  m_maxCookiesPerDomain
  m_count
  m_fqdnMyDomain

Update:
It seems sometimes it is failing. CI says it's also failing on Windows sometimes. My local Ubuntu 16.04 box just printed this, which is the wrong order:

  m_fqdnMyDomain
  m_domainTable
  m_maxCookieSize
  m_maxCookies
  m_maxCookiesPerDomain
  m_count

@ViktorHofer

Copy link
Copy Markdown
Member

@dotnet-bot test Innerloop Windows_NT Release x64 Build and Test

testing something

@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25503-01, preview3-25503-02, preview3-25503-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25503-02, preview3-25503-02, preview3-25503-01, respectively (release/2.0.0) Jul 3, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from 01e994a to 3824451 Compare July 3, 2017 21:53
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25503-02, preview3-25503-02, preview3-25503-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25503-02, preview3-25504-01, preview3-25503-01, respectively (release/2.0.0) Jul 4, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from 3824451 to 41c4757 Compare July 4, 2017 01:40
@dotnet-maestro-bot dotnet-maestro-bot changed the title Update CoreClr, CoreFx, Standard to preview3-25503-02, preview3-25504-01, preview3-25503-01, respectively (release/2.0.0) Update CoreClr, CoreFx, Standard to preview3-25504-01, preview3-25504-01, preview3-25503-01, respectively (release/2.0.0) Jul 4, 2017
@dotnet-maestro-bot
dotnet-maestro-bot force-pushed the release/2.0.0-UpdateDependencies branch from 41c4757 to 7b42c84 Compare July 4, 2017 04:16
@ViktorHofer

Copy link
Copy Markdown
Member

@dotnet-bot test Innerloop Tizen armel Debug Cross Build
@dotnet-bot test Innerloop Tizen armel Release Cross Build

@ViktorHofer

Copy link
Copy Markdown
Member

As CI is finally green here I will merge this to unblock the release branch and follow up on the serialization error here: https://github.com/dotnet/corefx/issues/21720

@ViktorHofer
ViktorHofer merged commit f61091c into dotnet:release/2.0.0 Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants