This repository was archived by the owner on Jan 23, 2023. It is now read-only.
More tests for enumerable. - #2326
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
In all of these min/max cases, it'd be good to have some more border cases tests, e.g. a source with one element, a source where the minimum value is MinValue, etc.
Contributor
Author
There was a problem hiding this comment.
Agreed. Shall add some more.
Member
|
Thanks for adding these tests. |
Member
|
cc: @VSadov |
JonHanna
force-pushed
the
enumerable_tests
branch
2 times, most recently
from
July 13, 2015 20:36
58318fd to
ef79496
Compare
Tests originally commited as part of pull-request dotnet#2237 moved out into separate pull-request. Consistently favour type names over c# names. Single element sequences on Min and Max (What other edge cases should we hit?) MinValue and MaxValue for element types. Min & Max with selector Remove tests on short-circuit/not short-circuit for now. More skip tests.
JonHanna
force-pushed
the
enumerable_tests
branch
from
July 13, 2015 23:43
ef79496 to
f8faadf
Compare
Member
There was a problem hiding this comment.
Thanks for adding these.
Nit: Other than this one blank line, looks like something may have happened with blank lines elsewhere in the file, i.e. there aren't any 😄 Would you mind adding some between members, as in the other files?
Member
|
Thanks! |
stephentoub
added a commit
that referenced
this pull request
Jul 14, 2015
More tests for enumerable.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
More tests for enumerable. Commit migrated from dotnet/corefx@125f88a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests originally commited as part of pull-request #2237
moved out into separate pull-request.