This repository was archived by the owner on Jan 23, 2023. It is now read-only.
SSLStream - Fix write renegotiation and make a single function for it - #24492
Merged
Conversation
Author
|
As an aside I am wracking my brain on how we can test this code flow better, but the only way with .net currently might just be some sort of unit tests that artificially get in there and force the situation. Hoping someone can come up with ideas on this? |
Author
|
@dotnet-bot Test Outerloop Windows x64 Debug Build |
Member
|
cc: @geoffkizer |
stephentoub
reviewed
Oct 17, 2017
| case LazyAsyncResult lazy: | ||
| lazy.InvokeCallback(); | ||
| break; | ||
| case TaskCompletionSource<int> tsc: |
stephentoub
approved these changes
Oct 17, 2017
Member
|
@dotnet-bot test this please |
Member
|
@dotnet-bot test Outerloop Linux x64 Release Build please |
pjanotti
pushed a commit
to pjanotti/corefx
that referenced
this pull request
Oct 31, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was taking a hard look at the code for triggering the callback after an async renegotiation for both read and write. The write side is currently missing the TaskCompletionSource call that was added, but seemed to drop out of my PR.
I have put this in and moved the duplicate code to a single function which is what I was prototyping on the read side to make that full async.