Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Reverts Cancellation on SslStream - #25199

Closed
Drawaes wants to merge 1 commit into
dotnet:masterfrom
Drawaes:RemoveCancellation
Closed

Reverts Cancellation on SslStream#25199
Drawaes wants to merge 1 commit into
dotnet:masterfrom
Drawaes:RemoveCancellation

Conversation

@Drawaes

@Drawaes Drawaes commented Nov 12, 2017

Copy link
Copy Markdown

Checking that this now passes the outerloop

Revert "Implement cancellation policy for sslstream."
This reverts commit f2c8a55.
@Drawaes

Drawaes commented Nov 12, 2017

Copy link
Copy Markdown
Author

@dotnet-bot test Outerloop Linux x64 Debug Build please
@dotnet-bot test Outerloop Linux x64 Release Build please

@Drawaes

Drawaes commented Nov 12, 2017

Copy link
Copy Markdown
Author

ref #25198

@Drawaes

Drawaes commented Nov 12, 2017

Copy link
Copy Markdown
Author

@dotnet-bot test Linux arm Release Build please

@Drawaes

Drawaes commented Nov 12, 2017

Copy link
Copy Markdown
Author

/cc @stephentoub

Okay so this has 1 socket failure on Suse for
Socket_StaticConnectAsync_HostNotFound

Which is unrelated, but it confirms that reverting the cancellation puts SslStream back into a functioning state. I would say it should be put back to here and cancellation can be looked at again.

#25198 Shows a no-op PR that has the failures

Ubuntu 14.04 seems to be non responsive for whatever reason, maybe they are all in use?

@Drawaes

Drawaes commented Nov 12, 2017

Copy link
Copy Markdown
Author

Outerloop Linux x64 Release Build — Build finished.

That outerloop finished fine, with 100% pass rate.

@Drawaes

Drawaes commented Nov 12, 2017

Copy link
Copy Markdown
Author

@dotnet-bot test Outerloop Linux x64 Debug Build please

@benaadams

Copy link
Copy Markdown
Member

Failure is SendAsync_ExpectedDiagnosticCancelledActivityLogging

at System.Diagnostics.RemoteExecutorTestBase.RemoteInvokeHandle.Dispose() in /mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_true_prtest/src/CoreFx.Private.TestUtilities/src/System/Diagnostics/RemoteExecutorTestBase.cs:line 205
at System.Net.Http.Functional.Tests.DiagnosticsTest.SendAsync_ExpectedDiagnosticCancelledActivityLogging() in /mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_true_prtest/src/System.Net.Http/tests/FunctionalTests/DiagnosticsTests.cs:line 589

Assume unrelated..?

/cc @stephentoub

@stephentoub

Copy link
Copy Markdown
Member

Thanks for investigating. Reverting in #25203.

@Drawaes
Drawaes deleted the RemoveCancellation branch November 13, 2017 12:01
@karelz karelz added this to the 2.1.0 milestone Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants