This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fixing spacing in S.Memory and S.Runtime refs - #26521
Merged
Merged
Conversation
weshaggard
reviewed
Jan 22, 2018
| public static double GetNumericValue(char ch) { throw null; } | ||
| public static double GetNumericValue(string s, int index) { throw null; } | ||
| public static System.Globalization.UnicodeCategory GetUnicodeCategory(char ch) { throw null; } | ||
| public static System.Globalization.UnicodeCategory GetUnicodeCategory(int codePoint) { throw null; } |
Member
There was a problem hiding this comment.
This was added recently so I don't expect it should be removed.
Author
|
I am going to ignore the Windows x64/x86 CI failures given https://github.com/dotnet/corefx/issues/26531 |
weshaggard
reviewed
Jan 23, 2018
weshaggard
left a comment
weshaggard
left a comment
Member
There was a problem hiding this comment.
LGTM - Thanks for updating the tool @ahsonkhan and refs.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fixing spacing in S.Memory and S.Runtime refs * Add back GetUnicodeCategory(int codePoint) to the S.R ref * Fix which class to add the GetUnicodeCategory(int) API Commit migrated from dotnet/corefx@5b1af42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From: #26518 (comment)
Related: dotnet/buildtools#1870
cc @weshaggard, @jkotas