This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable Span.ToString tests - #26663
Closed
ianhays wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@dotnet-bot test this please |
|
The tests will need to be updated based on this change #26726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the update to the ToString output for the slow span in #26467, we needed to reflect those changes in the fast span as well: dotnet/coreclr#16087
After dotnet/coreclr#16087 is merged and CoreFX is updated to use the new coreclr version, this PR should be merged to enable the simple ToString tests that were already reviewed and merged in #26467 but not yet added to the csproj.
cc: @ahsonkhan
related to https://github.com/dotnet/corefx/issues/26295