This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Vectorize {RO}Span.IndexOf for T = char, similar to T = byte. - #28464
Merged
Conversation
jkotas
reviewed
Mar 26, 2018
| @@ -3,11 +3,14 @@ | |||
| // See the LICENSE file in the project root for more information. | |||
Member
There was a problem hiding this comment.
Should this be in its own .char.cs file? We are likely going to have quite a few char-specific SpanHelpers.
Author
There was a problem hiding this comment.
I think it should, as soon as we add char-specific helpers for the other APIs (for example the IndexOf variants). We can move them when we get a 2nd helper method.
Member
|
We should switch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dotnet/extensions#324 (comment)
cc @gfoidl, @jkotas, @benaadams, @AndyAyersMS, @davidfowl, @atsushikan, @eerhardt