This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port "Add config to force OpenSsl error queue cleanup before Encrypt/Decrypt" to 2.1 - #29443
Closed
pjanotti wants to merge 1 commit into
Closed
Port "Add config to force OpenSsl error queue cleanup before Encrypt/Decrypt" to 2.1#29443pjanotti wants to merge 1 commit into
pjanotti wants to merge 1 commit into
Conversation
dotnet#29186) * Add config to force OpenSsl error queue cleanup before Encrypt/Decrypt This is a escape valve in case the optimization of removing the calls to ERR_clear_error() for each SSL_write/SSL_read causes troubles. There will be a performance impact but depending on the scenario it can be a desired trade-off. Fixes #29188
Contributor
Author
|
Closing PR since it was decided to not add this config at this time, later I will remove it from master too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of PR (#29186)
This is a escape valve in case the optimization of removing the calls to ERR_clear_error() for each SSL_write/SSL_read causes troubles (we did various changes to minimize this possibility but due to the nature of OpenSsl error queue is not possible to guarantee that this won't ever happens). There will be a performance impact if the optimization is off but depending on the scenario it can be a desirable trade-off.
Fixes #29188