Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update tools/Configurations.props to also include netfx - #31952

Merged
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:ilproj-sdk
Aug 25, 2018
Merged

Update tools/Configurations.props to also include netfx#31952
tannergooding merged 1 commit into
dotnet:masterfrom
tannergooding:ilproj-sdk

Conversation

@tannergooding

@tannergooding tannergooding commented Aug 25, 2018

Copy link
Copy Markdown
Member

@tannergooding

tannergooding commented Aug 25, 2018

Copy link
Copy Markdown
Member Author

CC. @MattGal, @weshaggard, @eerhardt

@tannergooding

tannergooding commented Aug 25, 2018

Copy link
Copy Markdown
Member Author

Interestingly, the NETFX x86 Release Build passed on CI for #31512, but doing .\build.cmd -- /p:TargetGroup=netfx failed locally.

@tannergooding
tannergooding merged commit 9c32524 into dotnet:master Aug 25, 2018
@tannergooding

tannergooding commented Aug 26, 2018

Copy link
Copy Markdown
Member Author

Confirmed that the latest netfx official build has passed.

@karelz karelz added this to the 3.0 milestone Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@danmoseley danmoseley danmoseley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tannergooding @danmoseley @karelz