Units for BitOps.TrailingZeroCount

[grant-d]

Units for BitOps from related PRs: LZCNT, LOG2, TZCNT, ROTL/R, POPCNT

cc @tannergooding, @jkotas

[grant-d]

@stephentoub it's failing due to this line in the CoreCLR sources - I am not familiar with what that line imports. Any advice on how to fix this, perhaps that line can be removed? Or I need a suitable #if.

...BitOps.cs(9,7): error CS0246: The type or namespace name 'Internal' could not be found...

using Internal.Runtime.CompilerServices;

[Edit] It needs that line for access to Unsafe.AddByteOffset.
Not sure how to mitigate the issue on this side.

[grant-d]

Tests are failing due to this code in BitOps. It's missing the explicit conversion to IntPtr, which was apparently fine on Windows but not Linux et al.
I will fix in the next push I make in coreclr.

public static int TrailingZeroCount(uint value)
    ....
    return Unsafe.AddByteOffset(
        ref MemoryMarshal.GetReference(s_TrailingZeroCountDeBruijn),
        (IntPtr)(((value & -value) * 0x077CB531u) >> 27)); // <--- (IntPtr)

[stephentoub]

Any advice on how to fix this, perhaps that line can be removed?

Your workaround of adding an empty namespace to the test file seems fine. Thanks.

[grant-d]

Jumped the gun. These won't pass until the sync from coreclr

[grant-d]

We can remove this once BitOps is exposed

[grant-d]

We can remove this once BitOps is exposed

[grant-d]

@dotnet-bot test corefx-ci (Linux x64_Release) please

[grant-d]

/azp run corefx-ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[grant-d]

/azp test corefx-ci (Linux x64_Release)

[grant-d]

/azp run corefx-ci (Linux x64_Release)

[azure-pipelines]

No pipelines are associated with this pull request.

[grant-d]

Can we merge?

[grant-d]

Thanks for approving Jan, LGTM?