This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Plumb cancellation through SslStream.AuthenticateAsXxAsync - #37259
Merged
Conversation
wfurt
approved these changes
Apr 29, 2019
wfurt
left a comment
wfurt
left a comment
Member
There was a problem hiding this comment.
LGTM.
NETFX_x86_Release failure seems related to this change.
We accept a CancellationToken into several of the overloads, but it's then dropped and not actually used. This fixes that to ensure it's passed through to the underlying Read/WriteAsync operations.
stephentoub
force-pushed
the
sslcancellation
branch
from
April 29, 2019 18:46
6d85388 to
aa23c2b
Compare
Member
Author
|
/azp run corefx-outerloop-windows |
Member
Author
|
/azp run corefx-outerloop-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run corefx-outerloop-osx |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
Yeah, I needed to skip a test on netfx; it was relying on a fix in this PR. Thanks. |
Member
Author
|
The outerloop Linux failures are unrelated:
|
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…refx#37259) We accept a CancellationToken into several of the overloads, but it's then dropped and not actually used. This fixes that to ensure it's passed through to the underlying Read/WriteAsync operations. Commit migrated from dotnet/corefx@ff1db9b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We accept a CancellationToken into several of the overloads, but it's then dropped and not actually used. This fixes that to ensure it's passed through to the underlying Read/WriteAsync operations.
Fixes https://github.com/dotnet/corefx/issues/25206
cc: @davidsh, @geoffkizer, @wfurt, @Drawaes, @benaadams