This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix test failure in XmlWriterTraceListenerTests.ListenerWithFilter - #37368
Merged
Conversation
Member
Author
|
@ViktorHofer, lots of PRs (including this one) have been hitting this in the Packaging All Configurations build: Do you know what's going on? |
ViktorHofer
approved these changes
May 2, 2019
Member
This test randomly and somewhat amusingly failed in CI. The test validates that a particular value passed into one of the writer's methods doesn't show up in the output, but the writer also outputs the current process ID, and the process ID happened to match that value. The fix is to just ensure it doesn't.
stephentoub
force-pushed
the
textwriterfailure
branch
from
May 2, 2019 16:02
193ee6f to
bf79afa
Compare
safern
approved these changes
May 2, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…otnet/corefx#37368) This test randomly and somewhat amusingly failed in CI. The test validates that a particular value passed into one of the writer's methods doesn't show up in the output, but the writer also outputs the current process ID, and the process ID happened to match that value. The fix is to just ensure it doesn't. Commit migrated from dotnet/corefx@541d941
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test randomly and somewhat amusingly failed in CI. The test validates that a particular value passed into one of the writer's methods doesn't show up in the output, but the writer also outputs the current process ID, and the process ID happened to match that value. The fix is to just ensure it doesn't.
cc: @ViktorHofer, @wtgodbe, @krwq