This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix failing PostAsyncExpect100Continue_LateForbiddenResponse_Ok - #38742
Merged
Conversation
Member
|
For SendAsync_ConcurentSendReceive_Fail the cleanup is wrapped in try/catch block. Since we really do not care about the shutdown maybe we can add helper function to close without worrying about failures. That may be easier than add synchronization to every test with abnormal conditions. |
Member
Author
|
as we discussed offline with @wfurt, I'll add a helper method and review remaining tests for similar issues. |
davidsh
added
area-System.Net.Http
test bug
steveharter
pushed a commit
to steveharter/dotnet_corefx
that referenced
this pull request
Jun 25, 2019
…et#38742) * PostAsyncExpect100Continue: Keep client alive until server finishes * replace MRE with ShutdownIgnoringErrorsAsync
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…et/corefx#38742) * PostAsyncExpect100Continue: Keep client alive until server finishes * replace MRE with ShutdownIgnoringErrorsAsync Commit migrated from dotnet/corefx@bff9c7b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #38734
Seems 3fac6ad has uncovered a test issue.
The problem is that client gets diposed a bit too early causing unexpected errors