[master] Update dependencies from dotnet/corefx by dotnet-maestro[bot] · Pull Request #38753 · dotnet/corefx

dotnet-maestro · 2019-06-21T12:27:53Z

This pull request updates the following dependencies

From https://github.com/dotnet/corefx

Build: 20190621.1
Date Produced: 6/21/2019 9:37 AM
Commit: e5aa6a5
Branch: refs/heads/master
Updates:
- runtime.native.System.IO.Ports -> 4.6.0-preview7.19321.1
- Microsoft.NETCore.Platforms -> 3.0.0-preview7.19321.1

…621.1 - runtime.native.System.IO.Ports - 4.6.0-preview7.19321.1 - Microsoft.NETCore.Platforms - 3.0.0-preview7.19321.1

dotnet-maestro · 2019-06-21T12:32:55Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux x64_Debug)

wtgodbe · 2019-06-21T16:58:34Z

Wonky Helix reporting - looks like the tests passed, but didn't generate a testresults.xml -

Beginning reading of test results.
Uploading results in batches of size 1000
Searching '/datadisks/disk1/work/083780d0-8591-4bd3-bf84-4b795ef562eb/Work/8e4c9f1d-b07f-48ea-ba88-ed7b90aa79d7/Exec/..' for log files
Found log '/datadisks/disk1/work/083780d0-8591-4bd3-bf84-4b795ef562eb/Work/8e4c9f1d-b07f-48ea-ba88-ed7b90aa79d7/Exec/../console.488ed0a1.log'
Uri 'https://helixexternalresults.blob.core.windows.net/dotnet-corefx-refs-pull-38753-merge-083780d085914bd3bf/System.Net.Sockets.Tests/console.488ed0a1.log?sv=2017-07-29&sr=c&sig=pnniEE74ySrUaWBUlFvG8azyVHqQjKrRKXZ4xZ3Rzqo%3D&se=2019-07-01T12%3A54%3A13Z&sp=rl'
Generated log list:
console.488ed0a1.log

Searching '/datadisks/disk1/work/083780d0-8591-4bd3-bf84-4b795ef562eb/Work/8e4c9f1d-b07f-48ea-ba88-ed7b90aa79d7/Exec' for test results files
No results file found in any of the following formats: xunit, junit, trx
Main thread finished queueing batches
Worker 0: uploaded 1 results
Main thread exiting

date -u +%FT%TZ
2019-06-21T13:01:01Z

/usr/bin/python3 /datadisks/disk1/work/083780d0-8591-4bd3-bf84-4b795ef562eb/Payload/xunit-reporter.py
2019-06-21 13:01:01,639: ERROR: xunit-reporter(69): main: Unable to report xunit results: no test results xml file found.

exit 134

@MattGal is this a known issue? Or am I misreading the log?

In either case, merging

MattGal · 2019-06-21T17:08:54Z

@wtgodbe you're misreading the log I believe, there's no results because Xunit run segfaulted before writing it?

Relevant snippets from your log:

+ /usr/bin/python3 /datadisks/disk1/work/083780d0-8591-4bd3-bf84-4b795ef562eb/Payload/xunit-reporter.py
2019-06-21 13:01:01,639: ERROR: xunit-reporter(69): main: Unable to report xunit results: no test results xml file found.
+ exit 134

and

  Discovering: System.Net.Sockets.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Net.Sockets.Tests (found 733 of 1089 test cases)
  Starting:    System.Net.Sockets.Tests (parallel test collections = on, max threads = 2)
    System.Net.Sockets.Tests.DualModeConnectToDnsEndPoint.DualModeConnect_DnsEndPointToHost_Helper [SKIP]
      Condition(s) not met: "LocalhostIsBothIPv4AndIPv6"
    System.Net.Sockets.Tests.DualModeConnectAsync.DualModeConnectAsync_Static_DnsEndPointToHost_Helper [SKIP]
      Condition(s) not met: "LocalhostIsBothIPv4AndIPv6"
    System.Net.Sockets.Tests.DualModeConnectAsync.DualModeConnectAsync_DnsEndPointToHost_Helper [SKIP]
      Condition(s) not met: "LocalhostIsBothIPv4AndIPv6"
Unhandled exception. System.Net.Sockets.SocketException (22): Invalid argument
   at System.Net.Sockets.Socket.DoBeginAccept(Socket acceptSocket, Int32 receiveSize, AcceptOverlappedAsyncResult asyncResult) in /_/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3677
   at System.Net.Sockets.Socket.BeginAccept(Socket acceptSocket, Int32 receiveSize, AsyncCallback callback, Object state) in /_/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3641
   at System.Net.Sockets.Socket.BeginAccept(Int32 receiveSize, AsyncCallback callback, Object state) in /_/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3618
   at System.Net.Sockets.Socket.BeginAccept(AsyncCallback callback, Object state) in /_/src/System.Net.Sockets/src/System/Net/Sockets/Socket.cs:line 3607
   at System.Net.Sockets.Tests.SocketTestServerAPM.OnAccept(IAsyncResult result) in /_/src/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs:line 82
   at System.Net.LazyAsyncResult.Complete(IntPtr userToken) in /_/src/Common/src/System/Net/LazyAsyncResult.cs:line 397
   at System.Net.ContextAwareResult.CompleteCallback() in /_/src/Common/src/System/Net/ContextAwareResult.cs:line 394
   at System.Net.ContextAwareResult.<>c.<Complete>b__17_0(Object s) in /_/src/Common/src/System/Net/ContextAwareResult.cs:line 388
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) in /_/src/System.Private.CoreLib/shared/System/Threading/ExecutionContext.cs:line 172
--- End of stack trace from previous location where exception was thrown ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) in /_/src/System.Private.CoreLib/shared/System/Threading/ExecutionContext.cs:line 201
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) in /_/src/System.Private.CoreLib/shared/System/Threading/ExecutionContext.cs:line 132
   at System.Net.ContextAwareResult.Complete(IntPtr userToken) in /_/src/Common/src/System/Net/ContextAwareResult.cs:line 388
   at System.Net.LazyAsyncResult.ProtectedInvokeCallback(Object result, IntPtr userToken) in /_/src/Common/src/System/Net/LazyAsyncResult.cs:line 351
   at System.Net.LazyAsyncResult.InvokeCallback(Object result) in /_/src/Common/src/System/Net/LazyAsyncResult.cs:line 358
   at System.Net.Sockets.BaseOverlappedAsyncResult.CompletionCallback(Int32 numBytes, SocketError errorCode) in /_/src/System.Net.Sockets/src/System/Net/Sockets/BaseOverlappedAsyncResult.Unix.cs:line 29
   at System.Net.Sockets.AcceptOverlappedAsyncResult.CompletionCallback(IntPtr acceptedFileDescriptor, Byte[] socketAddress, Int32 socketAddressLen, SocketError errorCode) in /_/src/System.Net.Sockets/src/System/Net/Sockets/AcceptOverlappedAsyncResult.Unix.cs:line 44
   at System.Net.Sockets.SocketAsyncContext.AcceptOperation.InvokeCallback(Boolean allowPooling) in /_/src/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncContext.Unix.cs:line 595
   at System.Net.Sockets.SocketAsyncContext.OperationQueue`1.ProcessAsyncOperation(TOperation op) in /_/src/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncContext.Unix.cs:line 888
   at System.Net.Sockets.SocketAsyncContext.ProcessAsyncReadOperation(ReadOperation op) in /_/src/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncContext.Unix.cs:line 1295
   at System.Net.Sockets.SocketAsyncContext.ReadOperation.System.Threading.IThreadPoolWorkItem.Execute() in /_/src/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncContext.Unix.cs:line 332
   at System.Threading.ThreadPoolWorkQueue.Dispatch() in /_/src/System.Private.CoreLib/shared/System/Threading/ThreadPool.cs:line 677
   at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback() in /_/src/System.Private.CoreLib/src/System/Threading/ThreadPool.CoreCLR.cs:line 29
./RunTests.sh: line 164: 17784 Aborted                 (core dumped) "$RUNTIME_PATH/dotnet" xunit.console.dll System.Net.Sockets.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=nonnetcoreapptests -notrait category=nonlinuxtests -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing $RSP_FILE
/datadisks/disk1/work/083780d0-8591-4bd3-bf84-4b795ef562eb/Work/8e4c9f1d-b07f-48ea-ba88-ed7b90aa79d7/Exec
----- end Fri Jun 21 13:00:52 UTC 2019 ----- exit code 134 ----------------------------------------------------------
exit code 134 means SIGABRT Abort. Managed or native assert, or runtime check such as heap corruption, caused call to abort(). Core dumped.
Looking around for any Linux dump...

wtgodbe · 2019-06-21T17:17:28Z

@tmds does this look related to #37486?

tmds · 2019-06-21T20:12:57Z

Yes, I think so.
It looks like an async accept that is scheduled to complete, but the listen socket being disposed when the accept call is made.
The SocketError doesn't match the expected values:

corefx/src/Common/tests/System/Net/Sockets/SocketTestServerAPM.cs

Lines 58 to 59 in a10890f

    
           e.SocketErrorCode == SocketError.OperationAborted || 
        
           e.SocketErrorCode == SocketError.Interrupted)

We need to convert it with a Cleanup check like in https://github.com/dotnet/corefx/pull/37486/files#diff-a92dcc50fa7799a1b77b747a99c6222bR5270.

I'll take a look next week. If it is causing many CI failures, you can add SocketError for SocketException (22): Invalid argument to the SocketTestServerAPM.cs as a temporary workaround.

…621.1 (dotnet#38753) - runtime.native.System.IO.Ports - 4.6.0-preview7.19321.1 - Microsoft.NETCore.Platforms - 3.0.0-preview7.19321.1

Update dependencies from https://github.com/dotnet/corefx build 20190…

92fc779

…621.1 - runtime.native.System.IO.Ports - 4.6.0-preview7.19321.1 - Microsoft.NETCore.Platforms - 3.0.0-preview7.19321.1

wtgodbe merged commit 087d037 into master Jun 21, 2019

wtgodbe deleted the darc-master-02e88ff5-623a-4343-b0fc-4f18c8923d9b branch June 21, 2019 16:59

karelz added this to the 3.0 milestone Jul 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[master] Update dependencies from dotnet/corefx - #38753

[master] Update dependencies from dotnet/corefx#38753
wtgodbe merged 1 commit into
masterfrom
darc-master-02e88ff5-623a-4343-b0fc-4f18c8923d9b

dotnet-maestro Bot commented Jun 21, 2019

Uh oh!

dotnet-maestro Bot commented Jun 21, 2019 •

edited

Loading

Uh oh!

wtgodbe commented Jun 21, 2019 •

edited

Loading

Uh oh!

MattGal commented Jun 21, 2019

Uh oh!

wtgodbe commented Jun 21, 2019

Uh oh!

tmds commented Jun 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

dotnet-maestro Bot commented Jun 21, 2019

From https://github.com/dotnet/corefx

Uh oh!

dotnet-maestro Bot commented Jun 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

wtgodbe commented Jun 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MattGal commented Jun 21, 2019

Uh oh!

wtgodbe commented Jun 21, 2019

Uh oh!

tmds commented Jun 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dotnet-maestro Bot commented Jun 21, 2019 •

edited

Loading

wtgodbe commented Jun 21, 2019 •

edited

Loading