Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/3.0] Move corefx to stages, use arcade's package artifacts convention - #40205

Merged
ViktorHofer merged 3 commits into
dotnet:release/3.0from
safern:PortYamlStages
Aug 10, 2019
Merged

[release/3.0] Move corefx to stages, use arcade's package artifacts convention#40205
ViktorHofer merged 3 commits into
dotnet:release/3.0from
safern:PortYamlStages

Conversation

@safern

@safern safern commented Aug 9, 2019

Copy link
Copy Markdown
Member

Same as: #40198 but with a full arcade update.

Demo build: https://dev.azure.com/dnceng/internal/_build/results?buildId=303622

Port #40126 to 3.0

Description
Changes our build templates to use azure devops stages and include Arcade publish system with signing and nuget validation. Also, changes the directory structure on how we bin place packages in the artifacts dir to follow arcade's convention based on Shipping and NonShipping.

Customer Impact
None.

Regression?
No.

Risk
Low.

Easier to review by hiding white spaces.

Also I added a full arcade update to bring in the necessary yaml and script files for this to work.

cc: @danmosemsft

safern added 2 commits August 9, 2019 14:58
…net#40124)

* Move corefx to stages, use package artifacts convention start transition to use arcade publish tasks

* Update arcade dependencies from build 20190808.13
@danmoseley

Copy link
Copy Markdown

I think this Stages work is implicitly tactics-approved, so you can just merge when ready. It's a big change though, so you might want a couple signoffs if this isn't identical to the one in master?

@safern

safern commented Aug 10, 2019

Copy link
Copy Markdown
Member Author

if this isn't identical to the one in master?

It is identical to the one in master but this one includes an arcade update to the eng\common folder as we need those files for the stages to work.

@danmoseley

Copy link
Copy Markdown

Well go ahead and merge when you believe this was appropriately validated.

cc @eerhardt for nex tweek.

@ViktorHofer

Copy link
Copy Markdown
Member

I'm already working on a fix for the netfx leg.

@ViktorHofer
ViktorHofer merged commit 10c29aa into dotnet:release/3.0 Aug 10, 2019
@safern
safern deleted the PortYamlStages branch August 12, 2019 16:29
@karelz karelz added this to the 3.0 milestone Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants