Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/3.1] Corresponding unit tests for dotnet/coreclr#28014 - #42862

Merged
wtgodbe merged 1 commit into
dotnet:release/3.1from
GrabYourPitchforks:str_replace_31
Feb 19, 2020
Merged

[release/3.1] Corresponding unit tests for dotnet/coreclr#28014#42862
wtgodbe merged 1 commit into
dotnet:release/3.1from
GrabYourPitchforks:str_replace_31

Conversation

@GrabYourPitchforks

Copy link
Copy Markdown
Member

These are the unit tests for dotnet/coreclr#28014, which is a customer-reported infinite loop in string.Replace.

The unit tests will fail (by entering an infinite loop) until that PR is checked in to coreclr and the corresponding build flows to corefx.

@wtgodbe

wtgodbe commented Feb 18, 2020

Copy link
Copy Markdown
Member

https://dev.azure.com/dnceng/internal/_build/results?buildId=526518 is the build that contains the CoreClr change, we can re-run this after we ingest that build

@wtgodbe

wtgodbe commented Feb 19, 2020

Copy link
Copy Markdown
Member

Here's the PR ingesting the CoreClr change: #42865 We should re-run CI after that's merged

@GrabYourPitchforks

Copy link
Copy Markdown
Member Author

These are just unit tests - there's no behavioral change as part of this PR. It's ok if this PR slips past the 3.1.3 checkin deadline.

@wtgodbe

wtgodbe commented Feb 19, 2020

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wtgodbe
wtgodbe merged commit bcfd3d3 into dotnet:release/3.1 Feb 19, 2020
@GrabYourPitchforks
GrabYourPitchforks deleted the str_replace_31 branch February 21, 2020 05:04
@danmoseley danmoseley modified the milestones: 3.1.x, 3.1.3 Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants