This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Update use of NonPortableCast to MemoryMarshal.Cast and cleanup - #2092
Merged
Conversation
Member
|
I assume VS generated all the formatting changes and this wasn't done by hand? 😄 |
joshfree
approved these changes
Jan 31, 2018
Contributor
Author
|
@dotnet-bot test Innerloop OSX10.12 Release Build and Test |
Contributor
Author
Yes :) |
Member
|
Also, could you create tracking issues for any intermittent test failures in CI? |
| Random r = new Random(42324232); | ||
| for (int i = 0; i < ints.Length; i++) { ints[i] = r.Next(); } | ||
| var bytes = ints.AsSpan().NonPortableCast<int, byte>(); | ||
| var bytes = MemoryMarshal.Cast<int, byte>(ints.AsSpan()); |
Member
There was a problem hiding this comment.
Why are you changing it to Cast and not to TryCast?
Contributor
Author
There was a problem hiding this comment.
It wasn't TryCast before. And we don't have that yet.
Contributor
Author
The failures are coming from the already known issue: #2062 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2089
Reacting to recent API changes from dotnet/corefx#26467
cc @dotnet/corefxlab-contrib