This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Fix debugger stepping into virtual calls - #5031
Merged
MichalStrehovsky merged 2 commits intoNov 27, 2017
Merged
Conversation
jkotas
reviewed
Nov 27, 2017
| switch (target.Architecture) | ||
| { | ||
| case TargetArchitecture.X64: | ||
| offset = 3; |
Member
There was a problem hiding this comment.
Comment on what this magic number is?
jkotas
approved these changes
Nov 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simpler fix than #4740 and gets the job done. It only uses the existing infrastructure we already have for line number emission. It's a little bit less elegant (not "correct by construction"), but we guard correctness with an assert.