This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merge nmirror to master - #5077
Merged
Merged
Conversation
Merge master to nmirror
Merge master to nmirror
Merge master to nmirror
Merge master to nmirror
The existing sha256 hash based naming for readonly data blob encounters a hash collision for the following data surprisingly. 5000540002400070005500025000 2000320001400040003300015000 To fix this, this change names data blobs based on their associated field handles. In ProjectX read only data are only used for array initializations and they are always associated with a data field. This ensures a unique naming while reducing the cost of sha256 hashing. Empty string dependency added. Also do not explicitly require data blobs and strings with the CoreRT dependency based approach since they are always reported to CoreRT during method compilation. [tfs-changeset: 1683122]
Merge changes from TFS
This is a very mild reliability and perf boost. The issue described in dotnet/roslyn#4388 has been fixed and we no longer need to check every typed handler and compare it to MRT's System.Object EEType when looking for a handler. [tfs-changeset: 1683270]
Merge changes from TFS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.