This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merge changes from TFS - #5080
Merged
Merged
Conversation
Certain types of symbols are concatenated from multiple type/methods names which can end up very complex and beyond the size limit. This change truncates those names to a limit with a sha256 hash appended after the truncation to ensure name uniqueness. I've make the moving truncating routines from UTC name mangler to the linkage names so that we do the truncation for general names instead of specific names. Also remove redundant code between the linkage names and the object writer. [tfs-changeset: 1683391]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merging, this PR, please ensure a merge commit is created as automation requires the merge commit. Do not 'Squash and merge' or 'Rebase and merge'!