This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Manual mirror of changes from dotnet/coreclr - PR 15410 - #5081
Closed
ahsonkhan wants to merge 1 commit into
Closed
Conversation
Member
|
Mirroring the PRs manually breaks the mirror and causes it to stop mirroring due to merge conflicts. I can take a look at why the PR was not mirrored and reset the mirror to pick it up. |
Member
|
There where 2 commits that where missing, the mirror was down due to github API exception. Just restarted it and it picked up those 2 commits before this one. Once #5083 is merged this should be picked up, if not I'll take a look. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional integer offset to OwnedMemory Pin [mirror]
Is the mirror to CoreRT broken?
I don't see this PR from coreclr mirrored in corert, resulting in the CI failure (in here - dotnet/corefx#25787).
https://ci3.dot.net/job/dotnet_corefx/job/master/job/windows-TGroup_uapaot+CGroup_Release+AGroup_x86+TestOuter_false_prtest/6041/console
cc @jkotas, @safern, @stephentoub