This repository was archived by the owner on Nov 1, 2020. It is now read-only.
[WIP] Package build - #5133
Closed
A-And wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
build-packagesto the standard build command.Until #4983 and #5123 CoreRT has only supported a single NuGet package, referencing projects directly, which wouldn't interfere with our build and publish pipeline (any build errors would show up earlier).
However, with the ILCompiler (and others soon, hopefully) being added, the process to produce them would ideally be integrated into the overall build process.
This would mimic CoreCLR and CoreFX and correctly mark any failures in building NuGet packages
as build failures.