platform-exclusion.md: platform attributes should use Build not Version with Win10 - #170
Merged
Merged
Conversation
antonfirsov
changed the title
Contributor
That is correct, it should be same what SDK uses |
terrajobst
approved these changes
Feb 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to our conceptual documentation we should use Build not Version, eg.
windows10.0.18362instead ofwindows10.0.1903, otherwise it would be inconsistent with TFM-s and capability checking API-s. Also note that Windows 10 versions are switching to new a scheme (20H2,21H1...), which will make it impossible to use them with the attribute.Despite the 3 reviewers (!), I almost made a mistake in dotnet/runtime#45494, which is probably the first PR in our libs using a specific version with
SupportedOSPlatformAttribute. It was @filipnavara who spotted the mistake.@buyaa-n @jeffhandley @terrajobst please confirm if this is correct, I need to be 100% sure before merging that PR.