Port cross oxs-arm64 build support from runtime - #1642
Merged
Conversation
Contributor
Author
|
/cc @dotnet/dotnet-diag This needs a diag team review before it can be merged. |
hoyosjs
approved these changes
Oct 10, 2020
hoyosjs
left a comment
hoyosjs
left a comment
Member
There was a problem hiding this comment.
lgtm. Glanced quickly through the time changes given I'm no expert and they look fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports @janvorli osx-arm64 cross building work in dotnet/runtime#40435