Skip to content

Change GetCurrentTarget and GetService ret type from HResult to int #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-mustafin wants to merge 1 commit into from
Closed

Change GetCurrentTarget and GetService ret type from HResult to int #3103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SOS/SOS.Hosting/HostWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public HostWrapper(IHost host, Func<TargetWrapper> getTarget)
/// </summary>
/// <param name="targetWrapper">target wrapper address returned</param>
/// <returns>S_OK</returns>
private HResult GetCurrentTarget(IntPtr self, out IntPtr targetWrapper)
private int GetCurrentTarget(IntPtr self, out IntPtr targetWrapper)
{
TargetWrapper wrapper = _getTarget();
if (wrapper == null)
Expand All @@ -70,13 +70,13 @@ private delegate HostType GetHostTypeDelegate(
[In] IntPtr self);

[UnmanagedFunctionPointer(CallingConvention.Winapi)]
internal delegate HResult GetServiceDelegate(
internal delegate int GetServiceDelegate(
[In] IntPtr self,
[In] in Guid guid,
[Out] out IntPtr ptr);

[UnmanagedFunctionPointer(CallingConvention.Winapi)]
private delegate HResult GetCurrentTargetDelegate(
private delegate int GetCurrentTargetDelegate(
[In] IntPtr self,
[Out] out IntPtr target);

Expand Down
2 changes: 1 addition & 1 deletion src/SOS/SOS.Hosting/ServiceWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public COMCallableIUnknown GetServiceWrapper(in Guid serviceId)
/// <param name="serviceId">guid of the service</param>
/// <param name="service">pointer to return service instance</param>
/// <returns>S_OK or E_NOINTERFACE</returns>
public HResult GetService(IntPtr self, in Guid guid, out IntPtr ptr)
public int GetService(IntPtr self, in Guid guid, out IntPtr ptr)
{
ptr = IntPtr.Zero;

Expand Down