Port GCDump fixes from PerfView - #3475
Merged
Merged
Conversation
hoyosjs
approved these changes
Oct 20, 2022
hoyosjs
added a commit
that referenced
this pull request
Feb 1, 2023
Return to pre-large heap support cap of 10 million nodes. Prior to #3475 we capped analysis at 10M nodes. After removing the cap, we often find issues in processing data. There's often an imbalance between node's edge count and the number of available edges. The problem is this error yields no gcdump, so we're adding the cap back until the edge imbalance can be figured out or the dumper can be made resilient. This still hides the buggy behavior around large graphs until it gets further investigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet-gcdump broke when running on recent version of perfview, after investigation the root cause was that
Microsoft.Diagnostics.FastSerialization.SegmentedListhad itsCountfield changed from an int to a long.In the
Graph.ToStream()method we calledserializer.Write(m_nodes.Count)which would now write a 64 bit value, and when the deserializer expected a 32 bit value the deserializer would be 32 bits off and everything appeared corrupted.I went through all files that we keep copies of and took all the updates I could find, but that is the core one that fixes the issue.