Fix dbgshim fails to decode libcoreclr.so headers from Snap install - #3530
Merged
Conversation
Issue: dotnet#3510 Add GetBuildIdFromSectionHeader that used when getting the build id note from the program headers failures.
Contributor
Author
|
@gregg-miskelly when this build is finished for this PR can you test the libdbgshim.so? This covers the live debugging case, but I have no solution for the dump/OpenVirtualProcess case. |
tommcdon
reviewed
Dec 1, 2022
tommcdon
left a comment
tommcdon
left a comment
Member
There was a problem hiding this comment.
Left a comment for your review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3510
Add GetBuildIdFromSectionHeader that used when getting the build id note from the program headers failures.