Add new provider for gc-collect profile - #3531
Merged
Merged
Conversation
Member
Member
|
thanks @hoyosjs! I'm curious why those rundown events are there even though they are not in the list of events we collect for this profile? |
Contributor
|
Currently dotnet-trace is hardcoded to always request rundown, the We should generally have an option to skip rundown, I opened #3597 to track it. |
Member
|
great, thanks @dramos020 for doing this work, and @davmason for the new issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the profile mentioned in #3521 in order to include private gc events in the gc-collect profile. Can see this working by using the following sample application:
and dotnet-trace to collect a trace:
This results in the following events being generated, making note of the private gc events:
