Skip to content

[Dotnet-Monitor] [Feature Branch] Switched quantile to Percentile #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkeirstead merged 2 commits into from
Dec 21, 2022
Merged

[Dotnet-Monitor] [Feature Branch] Switched quantile to Percentile #3567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f62b559
Switched quantile to Percentile
kkeirstead Dec 19, 2022
92c03a1
Updating names to reflect the change to Percentile
kkeirstead Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.Diagnostics.Monitoring.EventPipe/Counters/TraceEventExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,12 +223,12 @@ private static void HandleHistogram(TraceEvent obj, CounterFilter filter, string
KeyValuePair<double, double>[] quantiles = ParseQuantiles(quantilesText);
foreach ((double key, double val) in quantiles)
{
string tagsWithQuantile = AppendQuantile(tags, FormattableString.Invariant($"quantile={key}"));
payload.Add(new PercentilePayload(meterName, instrumentName, null, unit, tagsWithQuantile, val, obj.TimeStamp));
string tagsWithPercentile = AppendPercentile(tags, FormattableString.Invariant($"Percentile={(int)(100*key)}"));
payload.Add(new PercentilePayload(meterName, instrumentName, null, unit, tagsWithPercentile, val, obj.TimeStamp));
}
}

private static string AppendQuantile(string tags, string quantile) => string.IsNullOrEmpty(tags) ? quantile : FormattableString.Invariant($"{tags},{quantile}");
private static string AppendPercentile(string tags, string percentile) => string.IsNullOrEmpty(tags) ? percentile : FormattableString.Invariant($"{tags},{percentile}");

private static void HandleHistogramLimitReached(TraceEvent obj, string sessionId, out ICounterPayload payload)
{
Expand Down