Skip to content

Add missing '$__CMakeArgs' option in build.sh - #3571

Merged
hoyosjs merged 1 commit into
dotnet:mainfrom
JongHeonChoi:keep_native_symbols
Jan 5, 2023
Merged

Add missing '$__CMakeArgs' option in build.sh#3571
hoyosjs merged 1 commit into
dotnet:mainfrom
JongHeonChoi:keep_native_symbols

Conversation

@JongHeonChoi

@JongHeonChoi JongHeonChoi commented Dec 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

build-commons.sh puts -DCLR_CMAKE_KEEP_NATIVE_SYMBOL=true to __CMakeArgs for keepnativesymbols option. Yet it is forgotten as build.sh doesn't use it.

diagnostics/eng/native/build-commons.sh

Lines 339 to 341 in 0007661

keepnativesymbols|-keepnativesymbols)
__CMakeArgs="$__CMakeArgs -DCLR_CMAKE_KEEP_NATIVE_SYMBOLS=true"
;;

@JongHeonChoi JongHeonChoi changed the title Add missing 'keepnativesymbols' option in build.sh Add missing '$__CMakeArgs' option in build.sh Dec 26, 2022
@JongHeonChoi

JongHeonChoi commented Dec 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@mikem8361 @hoyosjs @tommcdon
Who can review it? Please add the person in charge as a reviewer.

@hoyosjs
hoyosjs merged commit b164cb7 into dotnet:main Jan 5, 2023
@hoyosjs hoyosjs mentioned this pull request Feb 1, 2023
Merged
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JongHeonChoi @hoyosjs