[main] Source code updates from dotnet/dotnet - #5467
Conversation
|
|
|
The offending commit range is: dotnet/runtime@c4bc9b0...31289ef |
|
Hm actually, this has more test failures than #5461 |
|
Yes, these failures are different that #5461. In this PR's changes the DAC (i.e. mscordaccore.dll on Windows, etc) can't be loaded by SOS for some reason. |
|
We should really understand the issue here sooner than later. This could potentially unveil a product defect (as we now build the product from within the VMR) that would impact P4 as well. |
|
@ViktorHofer The latest results look good to me. It only fails due to source-build related issues: |
|
@dotnet/source-build can you please with unblocking the build? Note that this uses Arcade 9. |
|
@ViktorHofer this uses Arcade 10 |
|
Ah weird. With Arcade 10, prebuilt detection shouldn't even run. |
|
OK so we are in a torn state here because repo SB uses the arcade SB intermediate package which doesn't get updated by VMR backflow PRs (because we don't produce it there anymore). This means that all repos that get a newer Arcade via the VMR and have a SB repo job are in a torn state. We need to fix that. Unfortunately, I don't have perms to push to this PR. |
|
@ViktorHofer, should I just merge this PR? Even with the source build failures? |
|
Not yet. We are waiting on a source-build fix to flow in. I'm chatting with @hoyosjs if the dotnet/product-construction team can get at least write permissions here. |
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies