Skip to content

[main] Source code updates from dotnet/dotnet - #5467

Merged
dotnet-maestro[bot] merged 10 commits into
mainfrom
darc-main-db2bb9b3-e449-4ab6-b559-08f2f8fb7ce4
Apr 29, 2025
Merged

[main] Source code updates from dotnet/dotnet#5467
dotnet-maestro[bot] merged 10 commits into
mainfrom
darc-main-db2bb9b3-e449-4ab6-b559-08f2f8fb7ce4

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

ViktorHofer
ViktorHofer previously approved these changes Apr 24, 2025
vitek-karas
vitek-karas previously approved these changes Apr 24, 2025
@akoeplinger

akoeplinger commented Apr 24, 2025

Copy link
Copy Markdown
Member

The test failures here are the same as in #5461 so unrelated to the VMR.

@akoeplinger

Copy link
Copy Markdown
Member

The offending commit range is: dotnet/runtime@c4bc9b0...31289ef

@akoeplinger

Copy link
Copy Markdown
Member

Hm actually, this has more test failures than #5461

@mikem8361

Copy link
Copy Markdown
Contributor

Yes, these failures are different that #5461. In this PR's changes the DAC (i.e. mscordaccore.dll on Windows, etc) can't be loaded by SOS for some reason.

@ViktorHofer

ViktorHofer commented Apr 28, 2025

Copy link
Copy Markdown
Member

We should really understand the issue here sooner than later. This could potentially unveil a product defect (as we now build the product from within the VMR) that would impact P4 as well.

@akoeplinger

Copy link
Copy Markdown
Member

@ViktorHofer The latest results look good to me. It only fails due to source-build related issues:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.25227.101/tools/SourceBuild/AfterSourceBuild.proj(83,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 3 new pre-builts discovered! Detailed usage report can be found at /mnt/vss/_work/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.DotNet.Arcade.Sdk.10.0.0-beta.25227.101
Microsoft.DotNet.Build.Tasks.Feed.10.0.0-beta.25227.101
Microsoft.DotNet.SourceBuild.Tasks.10.0.0-beta.25227.101

@ViktorHofer

Copy link
Copy Markdown
Member

@dotnet/source-build can you please with unblocking the build? Note that this uses Arcade 9.

@akoeplinger

Copy link
Copy Markdown
Member

@ViktorHofer this uses Arcade 10

@ViktorHofer

Copy link
Copy Markdown
Member

Ah weird. With Arcade 10, prebuilt detection shouldn't even run.

@ViktorHofer

Copy link
Copy Markdown
Member

OK so we are in a torn state here because repo SB uses the arcade SB intermediate package which doesn't get updated by VMR backflow PRs (because we don't produce it there anymore). This means that all repos that get a newer Arcade via the VMR and have a SB repo job are in a torn state. We need to fix that.

Unfortunately, I don't have perms to push to this PR.

@mikem8361

Copy link
Copy Markdown
Contributor

@ViktorHofer, should I just merge this PR? Even with the source build failures?

@ViktorHofer

ViktorHofer commented Apr 28, 2025

Copy link
Copy Markdown
Member

Not yet. We are waiting on a source-build fix to flow in. I'm chatting with @hoyosjs if the dotnet/product-construction team can get at least write permissions here.

@dotnet-maestro
dotnet-maestro Bot merged commit c174aba into main Apr 29, 2025
@dotnet-maestro
dotnet-maestro Bot deleted the darc-main-db2bb9b3-e449-4ab6-b559-08f2f8fb7ce4 branch April 29, 2025 06:52
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants