feat(modern-template): respect url normalization for toc#9036
Closed
Lulalaby wants to merge 3 commits into
Closed
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #9036 +/- ##
==========================================
- Coverage 77.56% 77.56% -0.01%
==========================================
Files 591 591
Lines 24577 24577
==========================================
- Hits 19064 19063 -1
- Misses 5513 5514 +1 ☔ View full report in Codecov by Sentry. |
7d49d8f to
adb5614
Compare
Contributor
Author
|
Yeah that's basically what i mean, we should keep in mind for that issue tho, that it needs to work seamless with existing environments if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current problem
If you have something like .htaccess url rewrite active, the toc expansion does not work.
Example rewrite:
Screenshots
Proposed Solution
By adding a config option called
_urlNormalizationActiveand parsing this in the toc.ts of themoderntemplate asdocfx:urlnormalizationactive, we can achieve the toc expansion.Screenshots