Update preprocessor-pragma-checksum.md - #5059
Merged
Merged
Conversation
The guid is for the hash algorithm, not the file; And the example `checksum_bytes` is not "an even number of hexadecimal digits". see : https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/Portable/PEWriter/DebugSourceInfo.cs https://github.com/dotnet/roslyn/blob/master/src/Compilers/CSharp/Test/Emit/PDB/CheckSumTest.cs
BillWagner
added
the
✨ 1st-time docs contributor!
BillWagner
approved these changes
Apr 27, 2018
BillWagner
left a comment
BillWagner
left a comment
Member
There was a problem hiding this comment.
Thanks for spotting this and fixing it @OpportunityLiu We appreciate it.
I've reviewed the changes, and I'll 
now. You should see the changes on the live site in the next day or two, on our regular publishing cycle.
Thanks again for your first contribution to .NET Docs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guid is for the hash algorithm, not the file;
And the example
checksum_bytesis not "an even number of hexadecimal digits".see : https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/Portable/PEWriter/DebugSourceInfo.cs
https://github.com/dotnet/roslyn/blob/master/src/Compilers/CSharp/Test/Emit/PDB/CheckSumTest.cs
Summary
Describe your changes here.
Fixes #Issue_Number (if available)